-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added doc, benchmark and deps/X node core PR labels #32
Conversation
I'm merging this as no objections has been raised. |
post LGTM! ;) |
@williamkapke thanks! 😄 |
// order of entries in this map *does* matter for the resolved labels | ||
const subSystemLabelsMap = { | ||
// don't want to label it a c++ update when we're "only" bumping the Node.js version | ||
'c++': /^src\/(?!node_version\.h)/, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
belated LGTM. I'll try to find time to tackle some of the more complex ones soon |
nodejs/node#6432 Seems to have been labeled as |
Hmm, seems like this doesn't only label |
Woops, cause the old @Fishrock123 goodie! I'll be ready to deploy as soon as you've got a fix ready. |
This improves the current node core auto PR labelling functionality by supporting these extra labels:
doc
for exclusivedoc/*
changesbenchmark
for exclusivebenchmark/*
changesv8
,libuv
,openssl
etc when having changes indeps/X/*
Also ignores changes to
src/node_version.h
to avoid labelling that asc++
as mentioned in #31 (comment).@jbergstroem @mscdex @Fishrock123 does these labels sound reasonable to you?
Refs #31, nodejs/node#6247