Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bad node core PR exclusive labels. #34

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Conversation

phillipj
Copy link
Member

This fixes some bad labelling by ensuring that every file affected in the PR actually matches an exclusive label when we're checking for exclusive labels.

Refs nodejs/node#6448 nodejs/node#6432
Closes #33

This fixes some bad labelling by ensuring that *every* file affected in
the PR actually matches an exclusive label when we're checking for exclusive labels.

Refs nodejs/node#6448 nodejs/node#6432
Closes #33
@mscdex
Copy link
Contributor

mscdex commented Apr 28, 2016

👍

@Fishrock123
Copy link
Contributor

Nice use of .every(). LGTM

@phillipj phillipj merged commit a2c330d into master Apr 28, 2016
@phillipj phillipj deleted the fix-bad-labelling branch April 28, 2016 20:00
@phillipj
Copy link
Member Author

@mscdex @Fishrock123 deployed, hopefully it behaves better now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad tagging for test
3 participants