Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor labels to use Regex-keyed Maps #41

Merged
merged 2 commits into from
May 12, 2016
Merged

Refactor labels to use Regex-keyed Maps #41

merged 2 commits into from
May 12, 2016

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented May 12, 2016 •
edited
Loading

Allows for more extensibility where labels may be the same. (e.g. more than one $1 mapping)

Requires Node.js v6.0.0+ for the destructing in the for of loop.

cc @phillipj

@Fishrock123
Refactor labels to use Regex-keyed Maps
e217dfa 
Allows for more extensibility where labels may be the same.
@Fishrock123
Copy link
Contributor Author

v4 and v5 obviously fail with this

@phillipj
Copy link
Member

Nice refactoring 👍

While you're at it, could you remove v4 and v5 from .travis.yml, and set engines.node to ">= 6.0.0" in package.json? Otherwise it LGTM.

@Fishrock123 Fishrock123 mentioned this pull request May 12, 2016
Merged
@Fishrock123
Requires Node.js v6+
65db59c 
(Due to destructuring)
@Fishrock123
Copy link
Contributor Author

@phillipj done

@phillipj phillipj merged commit ef93782 into nodejs:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fishrock123 @phillipj