fix: pin glob to 10.3.4 #511
Merged
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can unpin it once the bot is running on Node.js 14.18 or newer. Fixes: nodejs/build#3720
richardlau
approved these changes
May 14, 2024
richardlau
reviewed
May 15, 2024
| @@ -24,7 +24,7 @@ | |||
| "dotenv": "^16.4.5", | |||
| "events-async": "^1.2.1", | |||
| "express": "^4.19.2", | |||
| "glob": "^10.3.15" | |||
| "glob": "10.3.14" | |||
There was a problem hiding this comment.
Apparently I fail at reading... was this supposed to be 10.3.4 like the PR/commit title?
There was a problem hiding this comment.
No, but we could try that. I chose 10.3.14 because 10.3.15 is the one where the "requires 14.18 or newer" commit first appears.
There was a problem hiding this comment.
I typo'ed the commit message (and the PR title was taken from the commit message). The previous version we shipped with was 10.3.12, so maybe we can try that.
There was a problem hiding this comment.
The require-a-newer-version-of-14.x commit was the first thing landed after the 10.3.13 release, further suggesting that 10.3.12 is the way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can unpin it once the bot is running on Node.js 14.18 or newer.
Fixes: nodejs/build#3720