gyp: fix XCode CLT version detection on Catalina

[cclauss]

Copies @szekelyisz nodejs/node-gyp#2141 to this repo.

[rvagg]

@szekelyisz: any idea what /usr/sbin/softwareupdate --history does with software that's since been removed? Is it possible that this will find an old CLI tools that is no longer there?

[szekelyisz]

@szekelyisz: any idea what /usr/sbin/softwareupdate --history does with software that's since been removed? Is it possible that this will find an old CLI tools that is no longer there?

@rvagg Hmm I didn't test that. AFAIK there's no (clean) way to roll back any update in macOS, and the package is gone, so the only way I can imagine to remove the tools is to delete the installation directory (usually /Library/Developer/CommandLineTools/). But in that case this patch will do exactly the same as happened before (compilation will fail with command not found or something).

[richardlau]

RSLGTM.

I'm not a mac user and don't have a way of verifying/testing this locally. I believe @BethGriggs has tested the nodejs/node-gyp#2141 patch against the gyp in core and was able to build Node.js but still got "No receipt for ..." warnings.

[ryzokuken]

RSLGTM. Can try testing this on MacOS, but it'll take me a while to get Catalina running.

[BethGriggs]

As @richardlau mentioned, I had seemingly related issue with Xcode on Catalina yesterday.

Before:

creating config.gypi
creating config.status
creating config.mk
running: 
    python tools/gyp_node.py --no-parallel -f make-mac
No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.
No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.
No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.
gyp: No Xcode or CLT version detected!
Error running GYP

After applying the patch from nodejs/node-gyp#2141 I was able to build (this was v10.x). The No receipt for ... warnings still appeared in the output though. I ended up just sudo rm -r /Library/Developer/CommandLineTools and reinstalling.

[lorenzopicoli]

When can we expect to have this merged and released?

[ryzokuken]

I'll merge this now since @BethGriggs has confirmed that it fixes the problem atleast to some extent. At some point in the near future, either me or @targos would make a release and update it in nodejs/node and nodejs/node-gyp.