This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Invalid header chars fix #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a C programmer, sorry for that.
Real use case: nginx + maxmind geobase + user from Düsseldorf will generate something like this
This request will cause empty response (with
HPE_INVALID_HEADER_TOKEN) from nodejs because ofü. And seems like it is valid character for headers (%x80-FF) but inIS_HEADER_CHARwe get a negative char value (cause of signed char is -127..127), so I just castedchto unsigned char before check.Bad things happened with nodejs v5.6.0 in this commit nodejs/node@98fde2f.