Skip to content
This repository has been archived by the owner on Jul 6, 2018. It is now read-only.

http2: test cases and other tweaks #178

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 12, 2017

Bunch of test cases ported from existing http tests, and a few changes to support them.

Note: this changes the way mapToHeader errors are reported on the client. In all cases, mapToHeader errors will be emitted in an 'error' event on the client side. On the server side, most mapToHeader errors are thrown synchronously with the notable exception of mapToHeaders errors thrown within the fetchTrailers event.

Also adds http2.getUnpackedSettings() as a reverse to http2.getPackedSettings()

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@jasnell jasnell changed the title Test cases http2: test cases and other tweaks Jul 12, 2017
mcollina

This comment was marked as off-topic.

sebdeckers

This comment was marked as off-topic.

@jasnell
Copy link
Member Author

jasnell commented Jul 12, 2017

@sebdeckers ... yep, I'm going to be taking a look at #167 later on today and will get that landed before this one.

@jasnell
Copy link
Member Author

jasnell commented Jul 13, 2017

@mcollina @sebdeckers updated!

sebdeckers

This comment was marked as off-topic.

sebdeckers

This comment was marked as off-topic.

sebdeckers

This comment was marked as off-topic.

PR-URL: nodejs#178
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
jasnell added a commit that referenced this pull request Jul 14, 2017
PR-URL: #178
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jul 14, 2017

Landed!

@jasnell jasnell closed this Jul 14, 2017
jasnell added a commit to jasnell/http2-1 that referenced this pull request Jul 14, 2017
PR-URL: nodejs#178
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants