Skip to content
This repository has been archived by the owner on Jul 6, 2018. It is now read-only.

more perf updates #21

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 25 additions & 21 deletions lib/internal/http2.js
Original file line number Diff line number Diff line change
Expand Up @@ -1307,17 +1307,19 @@ function initializeTLSOptions(options) {
return options;
}

function onErrorSecureServerSession(err, conn) {
if (!this.emit('clientError', err, conn))
conn.destroy(err);
}

class Http2SecureServerSession extends TLSServer {
constructor(options, requestListener) {
super(initializeTLSOptions(options), connectionListener);
this[kOptions] = options;
this.timeout = kDefaultSocketTimeout;
if (typeof requestListener === 'function')
this.on('request', requestListener);
this.on('tlsClientError', (err, conn) => {
if (!this.emit('clientError', err, conn))
conn.destroy(err);
});
this.on('tlsClientError', onErrorSecureServerSession);
}

setTimeout(msecs, callback) {
Expand Down Expand Up @@ -1475,9 +1477,8 @@ class Http2ClientSession extends EventEmitter {
this[kSocket] = socket;

const session = this[kSession] = createClientSession(options, socket);
socket.once('error', (error) => {
console.log(error);
});
// TODO remove this
socket.once('error', console.log);
socket.on('resume', socketOnResume);
socket.on('pause', socketOnPause);
socket.on('drain', socketOnDrain);
Expand Down Expand Up @@ -1605,20 +1606,7 @@ class Http2ClientRequest extends Http2Outgoing {
const _handle = this.stream.session.request(mapToHeaders(this[kHeaders]), true);
if (_handle instanceof http2.Http2Stream) {
this[kId] = _handle.getId();
this.stream.once('handle', () => {
if (this[kTrailers] instanceof Map) {
for (const v of this[kTrailers]) {
const key = String(v[0]);
const value = v[1];
if (Array.isArray(value) && value.length > 0) {
for (const item of value)
this.stream.addTrailer(key, String(item));
} else {
this.stream.addTrailer(key, String(value));
}
}
}
});
this.stream.once('handle', addTrailers)
this.stream._handle = _handle;
}
}
Expand All @@ -1629,6 +1617,22 @@ class Http2ClientRequest extends Http2Outgoing {
}
}

function addTrailers () {
const request = this[kRequest];
if (request[kTrailers] instanceof Map) {
for (const v of request[kTrailers]) {
const key = String(v[0]);
const value = v[1];
if (Array.isArray(value) && value.length > 0) {
for (const item of value)
this.addTrailer(key, String(item));
} else {
this.addTrailer(key, String(value));
}
}
}
}

class Http2ClientResponse extends Http2Incoming {
constructor(stream, headers, options) {
super(stream, headers, options);
Expand Down