Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Avoid nth-child for selecting p's in rendered markdown #175

Closed
aravindet opened this issue Feb 12, 2015 · 11 comments
Closed

Avoid nth-child for selecting p's in rendered markdown #175

aravindet opened this issue Feb 12, 2015 · 11 comments

Comments

@aravindet
Copy link

I understand why it is needed now, but this is likely to be hard to maintain in the long run. Localizers might add new paragraphs or change the structure in unpredictable ways.

There could be two ways to fix this:

  1. Use embedded HTML in the markdown files (translators have to be careful not to change them), or
  2. Split the homepage content into two markdown files (content-above-logo, content-below-logo), implement the logo box in the template HTML and use template.json strings to localize text within it.
@therebelrobot
Copy link
Contributor

That's a good point. I felt a little part of me die inside when I programmed that. I'll look into that as I do the template refactor this weekend.

@Fishrock123
Copy link
Contributor

Saw this today when looking at things. The version box should probably be mostly html. Styles should be generic for everything else and applied to header levels when necessary.

Extracting the header and footer into their own files for each translation may help.

@therebelrobot
Copy link
Contributor

Yeah, I was trying to go with a generic-as-possible template, but we will need to expand it a bit.

@Fishrock123
Copy link
Contributor

Should be fixed in #276

@snostorm
Copy link
Contributor

I'd be tempted to close this now even with #276 not merged, as it will be resolved soon. Or we can keep this until all groups move to the new homepage format?

@fhemberger
Copy link
Contributor

Pinging @nodejs/iojs-ar @nodejs/iojs-bg @nodejs/iojs-bn @nodejs/iojs-cn @nodejs/iojs-cs @nodejs/iojs-da @nodejs/iojs-de @nodejs/iojs-el @nodejs/iojs-es @nodejs/iojs-fa @nodejs/iojs-fi @nodejs/iojs-fr @nodejs/iojs-he @nodejs/iojs-hi @nodejs/iojs-hu @nodejs/iojs-id @nodejs/iojs-it @nodejs/iojs-ja @nodejs/iojs-ka @nodejs/iojs-ko @nodejs/iojs-mk @nodejs/iojs-ms @nodejs/iojs-nl @nodejs/iojs-no @nodejs/iojs-pl @nodejs/iojs-pt @nodejs/iojs-ro @nodejs/iojs-ru @nodejs/iojs-sv @nodejs/iojs-sw @nodejs/iojs-ta @nodejs/iojs-tr @nodejs/iojs-tw @nodejs/iojs-uk @nodejs/iojs-vi:

If you haven't already done so, please change to the new homepage format using template.json (see content/en).

(Phew, we have to come up with something better than this)

@fhemberger
Copy link
Contributor

Languages, which need to be updated:

  • @nodejs/iojs-el (PR waiting for +1)
  • @nodejs/iojs-es
  • @nodejs/iojs-fi
  • @nodejs/iojs-he
  • @nodejs/iojs-it
  • @nodejs/iojs-ko (PR waiting for +1)
  • @nodejs/iojs-no (PR waiting for +1)
  • @nodejs/iojs-pt (PR waiting for +1)
  • @nodejs/iojs-ru
  • @nodejs/iojs-tr (PR waiting for +1)
  • @nodejs/iojs-uk
  • @nodejs/iojs-tw (PR waiting for +1)
  • @nodejs/iojs-vi (PR waiting for +1)

@stringparser
Copy link
Contributor

For @nodejs/iojs-es the change was addressed in #362, we are missing the links.rss though so I'll do PR for this on a bit

@fhemberger
Copy link
Contributor

@stringparser Ah, sorry about that. I just had a quick look which languages still had the index.md in place. If the template.json version of the home page works fine for you, please remove the old index file.

@stringparser
Copy link
Contributor

@fhemberger no problem. You are right we still have the index.md :), I'll remove it.

fhemberger added a commit that referenced this issue Jul 11, 2015
update template for #175 from Taiwan
@fhemberger
Copy link
Contributor

I guess this won't be fixed for all i18n groups, so I'm closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants