-
Notifications
You must be signed in to change notification settings - Fork 130
Conversation
|
||
```sh | ||
iojs -p process.versions.v8 | ||
``` |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There's a not-yet-translated lgtm otherwise |
The de article should be removed. The point is that any articles not translated just aren't included. Long term this will be necessary anyway as the number of pages continues to grow. Since we're not yet linking to the i18n sections I'm also fine with having the "broken link" from the other two pages. I'll deal with falling back to the English articles automatically when we pseudo-404. |
We already have a PR pending for the ES6 page translation #229. |
#229 is blocked by merge conflicts though. When #229 is merge-ready and lands @fhemberger, the file will be returned to the The issue here is either we remove all extra English articles or none at all (as an ongoing policy.) Especially important as we start to add new pages soon |
Ok, than I'm fine with the removal. As a side note: This would probably also help to configure a fallback language. In this case, |
I agree with the remove all English articles from localized sites plan. However, should this be an issue that's +1ed by a majority (or whatever the minimum % of members established by the consensus seeking model is) of @iojs/website ? It seems like kind of a big decision in the long run, as it defines a strategy the website will be adopting. |
Yup. I just setup the Issue/PR so we can land it if approved. With a WG meeting on Monday I'm willing to see this wait a few days -- although it is also an easy enough PR to reverse. The risks to merging right now are fairly small though as this only affects content nobody is actually consuming. (The fallback case for the iojs/iojs-de repo is the single exception, although I'm not sure if anybody actually is linking to the |
I'm fine with removing un-used language directories, but if we remove individual pages we'll start having to adjust links all over the place so that they go to actual pages... |
Well, as soon as we add more pages, we're going to hit that issue regardless @Fishrock123. Probably best to figure out a technical solution for that now, before we link up the i18n folders for public consumption. |
Note this was updated to keep the @iojs/iojs-ru files now that they've landed in master. |
This branch now contains a "fallback" es6 file for the |
Approved the removal of empty articles in the WG meeting. I'll hold off merging for a little bit, pending some process improvement tinkering. |
…(until they are ready)
cb0cfe8
to
00c77ec
Compare
Cleaned up this PR (some groups since added content) and merging. |
Removes empty i18n articles #246
For #246