Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrections to Makefile and CMakeLists.txt for correct releases #170

Merged
merged 1 commit into from
Jul 30, 2022
Merged

corrections to Makefile and CMakeLists.txt for correct releases #170

merged 1 commit into from
Jul 30, 2022

Conversation

fduncanh
Copy link
Contributor

@fduncanh fduncanh commented Jul 30, 2022 •
edited
Loading

  1. replace previous "VERSION 6.0.5" by "VERSION _TAG_" in CMakelists.txt
  2. e.g. "TAG=6.0.7 make release" will now use sed to replace _TAG_ by 6.0.7 in release/CMakeLists.txt
  3. "make release" will also now include the recent addition libllhttp.pc.in when updating the release branch.

@fduncanh
update Makefile so e.g. "TAG=6.0.7 make release" works correctly again
6effe95 
1. replace previous "VERSION 6.0.5" by "VERSION _TAG_" in CMakelists.txt
2. e.g. "TAG=6.0.7 make release" will now use sed to replace _TAG_ by 6.0.7
   in release/CMakeLists.txt
3.  "make release" will also now include the new addition libllhttp.pc.in to
    when updating the release branch.
@fduncanh
Copy link
Contributor Author

@mcollina

Here are the fixes you requested for the release script.

@fduncanh
Copy link
Contributor Author

fduncanh commented Jul 30, 2022 •
edited
Loading

since you have already used tags 6.0.7 and 6.0.7a, I think you will need to repeat with TAG=6.0.7b

e.g.


make
TAG=6.0.7b make release

@fduncanh fduncanh mentioned this pull request Jul 30, 2022
Closed
mcollina
mcollina approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks, I'll ship as soon as I can

@mcollina mcollina merged commit 23a3e22 into nodejs:main Jul 30, 2022
@richardlau richardlau mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fduncanh @mcollina