Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for node 8.0 #81

Closed
3 tasks done
bnoordhuis opened this issue Apr 21, 2017 · 2 comments
Closed
3 tasks done

Prepare for node 8.0 #81

bnoordhuis opened this issue Apr 21, 2017 · 2 comments
Assignees
@bnoordhuis

Comments

@bnoordhuis
Copy link
Member

bnoordhuis commented Apr 21, 2017 •
edited
Loading

Wouldn't it be nice if llnode worked out of the box with node 8? Indeed it would but it won't happen without some even-toed ungulate clipping1. Here is what needs to be done:

  • update tools/gen-postmortem-metadata.py in upstream V8
  • back-port changes to nodejs/node
  • update llnode to support new object layouts

Bonus points if llnode is taught to print something sensible for WASM and Ignition stack frames/code objects/etc.

1yak shaving
@bnoordhuis bnoordhuis self-assigned this Apr 21, 2017
@bnoordhuis
Copy link
Member Author

Related V8 issue: No build bots build debug-support.cc

@bnoordhuis
Copy link
Member Author

V8 changes: https://codereview.chromium.org/2842843004/

@bnoordhuis bnoordhuis mentioned this issue Apr 28, 2017
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 1, 2017
@bnoordhuis
deps: cherry-pick bfae9db from upstream v8
6ed791c 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{nodejs#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
anchnk pushed a commit to anchnk/node that referenced this issue May 6, 2017
@bnoordhuis
deps: cherry-pick bfae9db from upstream v8
a38a7fc 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{nodejs#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this issue May 6, 2017
@bnoordhuis @targos
deps: cherry-pick bfae9db from upstream v8
9ed7dcd 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{nodejs#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to nodejs/node that referenced this issue May 6, 2017
@bnoordhuis @targos
deps: cherry-pick bfae9db from upstream v8
d74a545 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this issue Jun 6, 2017
@bnoordhuis @targos
deps: cherry-pick bfae9db from upstream v8
de93811 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{nodejs#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this issue Jun 7, 2017
@bnoordhuis @targos
deps: cherry-pick bfae9db from upstream v8
36ba9e6 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{nodejs#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to nodejs/node that referenced this issue Jun 17, 2017
@bnoordhuis @addaleax
deps: cherry-pick bfae9db from upstream v8
040582d 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to nodejs/node that referenced this issue Jun 21, 2017
@bnoordhuis @addaleax
deps: cherry-pick bfae9db from upstream v8
89afa81 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to nodejs/node that referenced this issue Jun 24, 2017
@bnoordhuis @addaleax
deps: cherry-pick bfae9db from upstream v8
9e574f6 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg pushed a commit to nodejs/node that referenced this issue Jun 29, 2017
@bnoordhuis @rvagg
deps: cherry-pick bfae9db from upstream v8
e8f486e 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to nodejs/node that referenced this issue Jul 11, 2017
@bnoordhuis @addaleax
deps: cherry-pick bfae9db from upstream v8
00b191f 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to nodejs/node that referenced this issue Jul 18, 2017
@bnoordhuis @addaleax
deps: cherry-pick bfae9db from upstream v8
2f17f46 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this issue Jul 21, 2017
@bnoordhuis @targos
deps: cherry-pick bfae9db from upstream v8
60afd95 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{nodejs#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to nodejs/node that referenced this issue Jul 24, 2017
@bnoordhuis @addaleax
deps: cherry-pick bfae9db from upstream v8
6204fad 
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnoordhuis bnoordhuis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnoordhuis