Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Node.js Foundation Modules Team Meeting 2018-03-14 #47

Closed
MylesBorins opened this issue Mar 12, 2018 · 23 comments
Closed

Node.js Foundation Modules Team Meeting 2018-03-14 #47

MylesBorins opened this issue Mar 12, 2018 · 23 comments

Comments

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 12, 2018 •
edited
Loading

Time

UTC Wed 14-Mar-2018 19:00 (07:00 PM):

Timezone Date/Time
US / Pacific Wed 14-Mar-2018 12:00 (12:00 PM)
US / Mountain Wed 14-Mar-2018 13:00 (01:00 PM)
US / Central Wed 14-Mar-2018 14:00 (02:00 PM)
US / Eastern Wed 14-Mar-2018 15:00 (03:00 PM)
London Wed 14-Mar-2018 19:00 (07:00 PM)
Amsterdam Wed 14-Mar-2018 20:00 (08:00 PM)
Moscow Wed 14-Mar-2018 22:00 (10:00 PM)
Chennai Thu 15-Mar-2018 00:30 (12:30 AM)
Hangzhou Thu 15-Mar-2018 03:00 (03:00 AM)
Tokyo Thu 15-Mar-2018 04:00 (04:00 AM)
Sydney Thu 15-Mar-2018 06:00 (06:00 AM)

Or in your local time:

Links

Agenda

Extracted from modules-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/modules

Approving PRs ~ 1 minute per item

  • doc: add meeting notes for 2018-02-28 #38

For awareness ~ 3 minutes per item

  • doc: add MANIFESTO.md #45
  • Use Cases Meeting #41
  • Online Module Summit #9

Discussion

  • Upstream changes to ESM in nodejs/node #42
    • 10 minute timebox
  • Use Cases for ESM in Node.js
    • 30 minute timebox

Invited

  • Modules team: @nodejs/modules

Notes

The agenda comes from issues labelled with modules-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting
@jkrems
Copy link
Contributor

jkrems commented Mar 12, 2018

Should we identify a single focus topic / deep dive for this meeting? E.g. getting a good, exhaustive list of use cases we can agree on? Or are we punting on that until April 3rd (or whenever the module summit will be)? It felt like the last meeting got dragged down by the back-and-forth between "answer minor question X" and "we need a general agreement on what we're trying to build here".

@mcollina
Copy link
Member

I'm traveling and I probably won't be able to join. I'm ok with whatever decision the team is going to make. Feel free to not count me towards quorum.

The agenda seems too big for one single meeting, should we prioritize a bit?

@jasnell
Copy link
Member

jasnell commented Mar 12, 2018

I will also be traveling and unable to make the call this week.

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Mar 12, 2018 via email

@inidaname
Copy link

inidaname commented Mar 12, 2018 via email

@benjamingr
Copy link
Member

Maybe weird request?

I'd prefer it if we started with technical discussion of the nodejs/node technical issues and I ask that people who would like to participate in that discussion enter the actual issues (I try to ping @nodejs/modules on issues when I see them).

Namely,

  • I'd love to hear an update about wasm from @linclark in "loader: allow importing wasm modules"
  • I'd love us to vote about the _ issue in "esm: provide named exports for all builtin libraries"

@weswigham
Copy link
Contributor

By "the underscore issue" do you mean filtering _ prefixed members from the exposed exports?

@guybedford
Copy link
Contributor

We can remove the mode: "esm" flag item from the agenda, as we already discussed this briefly last week.

@benjamingr
Copy link
Member

@weswigham yes

@guybedford how do we proceed with the esm flag item? Don't we need to make a decision about it?

@guybedford
Copy link
Contributor

@benjamingr I'm ok with putting this on the back-burner while we focus on other technical decisions and use cases.

@jdalton
Copy link
Member

jdalton commented Mar 13, 2018 •
edited
Loading

@benjamingr

I'd love us to vote about the _ issue in "esm: provide named exports for all builtin libraries"

The PR isn't blocked on filtering of _ at the moment. That was worked through a bit ago.

@benjamingr
Copy link
Member

@jdalton thanks for the update, reading it: I don't really understand why it's stalled. How can core move forward with named exports for ESM? What needs to be decided before the PR lands?

@jdalton
Copy link
Member

jdalton commented Mar 13, 2018 •
edited
Loading

@benjamingr

I don't really understand why it's stalled.

It's stuck on a console.log stack count nit at the moment.

What needs to be decided before the PR lands?

Minor things are left, for example now that live bindings of named exports works should setters still be filtered. That said, with the push to remove getter/setters from builtin module exports started before live bindings were thought possible and with things still being experimental, it may not be a super concern esp. for initial support.

@benjamingr
Copy link
Member

benjamingr commented Mar 13, 2018 •
edited
Loading

@jdalton thanks, is this something you think we need to discuss in the meeting, spin off into an issue here or discuss in the main nodejs/node repo? I really want to see named exports for native modules land :)

@jdalton
Copy link
Member

jdalton commented Mar 13, 2018 •
edited
Loading

@benjamingr

thanks, is this something you think we need to discuss in the meeting, spin off into an issue here or discuss in the main nodejs/node repo?

I think it just needs someone to pop-in and fix the console.log stack issue or better yet find the root cause of the console.log reference issue and fix that.

I really want to see named exports land :)

Same.

@benjamingr
Copy link
Member

@jdalton or @devsnek would either of you be willing to present the console.log extra stack frame issue in the meeting so we can solicit more eyes on it and land?

I'm opening another issue to discuss in the meantime

@devsnek
Copy link
Member

devsnek commented Mar 13, 2018

I can talk about it I guess, it was a concern originally brought up by @TimothyGu

@MylesBorins
Copy link
Contributor Author

I'd like to push us to avoid discussing general technical PRs in the meeting this week.

A rough agenda that I can update above if people are onboard (if yes please use emoji repsonse, if no please explain why)

  1. Quick review of outstanding PRs against this repo
  2. Reach consensus on how we should handle current PRs against core
  1. Discuss use cases and try and put together a base list that we reach consensus on in the meeting to avoid another 2 weeks before we can land anything

Thoughts?

@manekinekko
Copy link

@MylesBorins sorry I can't make it to today's meeting. Will catch up tomorrow.

@jkrems
Copy link
Contributor

jkrems commented Mar 14, 2018

I'll only be able to join but need to drop off after the first 30min.

@WebReflection
Copy link
Contributor

Apologies I'm unable to attend and, ultimately, unable to contribute much too ... thanks gosh I agree with whatever @jdalton says so I feel well represented 😅

If I cannot fix my useless presence in here I'd be happy to be moved to observer state ... just please give me some more time to figure out if I have those 5 hours of duty per week I've said I would.

Regards

@MylesBorins
Copy link
Contributor Author

Hey All, I've updated the agenda based on #47 (comment) which significantly simplifies the agenda and puts it into subcategories and time boxes for each discussion.

@MylesBorins
Copy link
Contributor Author

Here is the link to join y'all https://zoom.us/j/656987750

MylesBorins added a commit to MylesBorins/modules that referenced this issue Mar 15, 2018
@MylesBorins
doc: add meeting notes for 2018-03-14
5388eff 
refs: https://www.youtube.com/watch?v=U9xG4JPdznA
refs: nodejs#47
refs: https://docs.google.com/document/d/1fwQ_XkYyJO3p5fE2o9H9i7iWii0LB4OyQxepBlaa6-Y/edit
@MylesBorins MylesBorins mentioned this issue Mar 15, 2018
Merged
MylesBorins added a commit to MylesBorins/modules that referenced this issue Mar 15, 2018
@MylesBorins
doc: add meeting notes for 2018-03-14
4ea9e63 
closes: nodejs#47
refs: https://www.youtube.com/watch?v=U9xG4JPdznA
refs: https://docs.google.com/document/d/1fwQ_XkYyJO3p5fE2o9H9i7iWii0LB4OyQxepBlaa6-Y/edit
MylesBorins added a commit that referenced this issue Apr 25, 2018
@MylesBorins
doc: add meeting notes for 2018-03-14
36f34d2 
closes: #47
refs: https://www.youtube.com/watch?v=U9xG4JPdznA
refs: https://docs.google.com/document/d/1fwQ_XkYyJO3p5fE2o9H9i7iWii0LB4OyQxepBlaa6-Y/edit
@munrocket munrocket mentioned this issue Sep 1, 2023
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests