Don't use deprecated v8::Template::Set() in SetMethod

nodejs · Apr 27, 2016 · a90951e · a90951e · springmeyer · Apr 29, 2016
1 parent 7acd8ca
commit a90951e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/doc/methods.md b/doc/methods.md
@@ -474,9 +474,12 @@ Sets a method with a given name directly on a JavaScript object where the method
 Signature:
 
 ```c++
-template<typename T> void Nan::SetMethod(const T &recv,
-                                         const char *name,
-                                         Nan::FunctionCallback callback)
+void Nan::SetMethod(v8::Local<v8::Object> recv,
+                    const char *name,
+                    Nan::FunctionCallback callback)
+void Nan::SetMethod(v8::Local<v8::Template> templ,
+                    const char *name,
+                    Nan::FunctionCallback callback)
 ```
 
 <a name="api_nan_set_prototype_method"></a>

diff --git a/nan.h b/nan.h
@@ -1850,9 +1850,8 @@ NAN_INLINE void SetInstanceTemplate(
   SetTemplate(templ->InstanceTemplate(), name, value, attributes);
 }
 
-template<typename T>
 NAN_INLINE void SetMethod(
-    const T &recv
+    v8::Local<v8::Object> recv
   , const char *name
   , FunctionCallback callback) {
   HandleScope scope;
@@ -1863,6 +1862,17 @@ NAN_INLINE void SetMethod(
   recv->Set(fn_name, fn);
 }
 
+NAN_INLINE void SetMethod(
+    v8::Local<v8::Template> templ
+  , const char *name
+  , FunctionCallback callback) {
+  HandleScope scope;
+  v8::Local<v8::FunctionTemplate> t = New<v8::FunctionTemplate>(callback);
+  v8::Local<v8::String> fn_name = New(name).ToLocalChecked();
+  t->SetClassName(fn_name);
+  templ->Set(fn_name, t);
+}
+
 NAN_INLINE void SetPrototypeMethod(
     v8::Local<v8::FunctionTemplate> recv
   , const char* name, FunctionCallback callback) {