src: improve messages on CheckCast #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
==========================================
- Coverage 64.71% 64.51% -0.20%
==========================================
Files 3 3
Lines 1981 1987 +6
Branches 687 687
==========================================
Hits 1282 1282
- Misses 138 144 +6
Partials 561 561 ☔ View full report in Codecov by Sentry. |
vmoroz
reviewed
May 23, 2024
vmoroz
reviewed
May 23, 2024
Print actual value type if the check failed.
legendecas
force-pushed
the
check_cast_msg
branch
from
42315a7
to
0a5713d
Compare
gabrielschulhof
approved these changes
May 24, 2024
vmoroz
reviewed
May 31, 2024
vmoroz
reviewed
May 31, 2024
legendecas
force-pushed
the
check_cast_msg
branch
from
f65040c
to
f6d6af0
Compare
legendecas
force-pushed
the
check_cast_msg
branch
from
f6d6af0
to
4cfeb29
Compare
vmoroz
approved these changes
Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print actual value type if the check failed.
BEGIN_COMMIT_OVERRIDE
feat: improve messages on CheckCast (#1507)
END_COMMIT_OVERRIDE