Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v8.1.0 #1526

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 28, 2024

🤖 I have created a release beep boop

8.1.0 (2024-07-05)

Features

Bug Fixes

  • fix compilation for Visual Studio 2022 (#1492) (e011720)
  • restore ability to run under NAPI_EXPERIMENTAL (#1409) (40bcb09)

This PR was generated with Release Please. See documentation.

@github-actions github-actions bot changed the title chore(main): release 8.0.1 chore(main): release 8.1.0 Jun 28, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--node-addon-api branch 2 times, most recently from 062cca7 to c9693ef Compare June 28, 2024 16:00
@KevinEady
Copy link
Contributor

@legendecas ,

Should we also update the README.md to set the new version (or remove it completely so we don't have to constantly update it)?

@legendecas
Copy link
Member

@KevinEady yes, I think we can just remove the version number in README. Also, https://github.com/nodejs/node-addon-api/blob/main/doc/contributing/creating_a_release.md needs to be updated.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--node-addon-api branch from c9693ef to 155b7c4 Compare July 2, 2024 22:16
@github-actions github-actions bot force-pushed the release-please--branches--main--components--node-addon-api branch from 155b7c4 to 88a5fbd Compare July 5, 2024 13:23
@legendecas
Copy link
Member

It's really weird that release-please is not taking any configurations, even in my own setup legendecas#5. Will take a look again and trying to make a release sooner.

@legendecas
Copy link
Member

@github-actions github-actions bot changed the title chore(main): release 8.1.0 chore: release v8.1.0 Jul 5, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--node-addon-api branch from 88a5fbd to b942423 Compare July 5, 2024 15:49
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit bc5acef into main Jul 8, 2024
Copy link
Contributor Author

github-actions bot commented Jul 8, 2024

🤖 Created releases:

@legendecas
Copy link
Member

Release published: https://www.npmjs.com/package/node-addon-api/v/8.1.0

@legendecas legendecas deleted the release-please--branches--main--components--node-addon-api branch July 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants