Support for Asynchronous Thread-safe Function Calls #312

srirajpaul · 2018-07-30T21:17:13Z

Hello, Thank you for the effort to create and maintain the C++ wrappers for N-API. The wrappers make it very much easier to create native addons.

N-API added capability for additional threads to invoke JavaScript functions based on the processing completed by those threads. Is there any timeline/plan to add wrappers for the same?

https://nodejs.org/docs/latest-v10.x/api/n-api.html#n_api_asynchronous_thread_safe_function_calls

Thank you

romandev · 2018-07-30T22:27:47Z

I'll take this issue if there is no one actively working on this.

atoy40 · 2018-12-11T16:58:29Z

Hello,
any news on this one ? I've discovered this project https://github.com/mika-fischer/napi-thread-safe-callback, it seems to have the same goal but use libuv directly to achieve it.

romandev · 2018-12-11T17:06:33Z

Ah, I missed this.. I'm on a trip now. I'll finish to implement this until next week.

aazavid · 2019-01-22T12:33:15Z

How is the process going? It would be nice to get examples.

romandev · 2019-01-22T13:21:58Z

I tried to work on this issue for a while after a long vacation, but soon @DaAitch PR(#424) came up. I was too late and his PR looks reasonable to me. I believe he will finish the work soon. :)

DaAitch · 2019-01-24T21:44:59Z

@romandev I tought you're working on wrapping napi_threadsafe_function calls? I did not do that. I was working on a util method for making node calls from second thread easier.

romandev · 2019-01-29T08:15:40Z

@DaAitch Okay, thank you for explanation. I was lacking in understanding. I'll send a PR. Please review it when you have a spare time.

DaAitch · 2019-01-29T13:49:36Z

@romandev @mhdawson @gabrielschulhof

I think this needs some clarification now. Also in last Team meeting it was said, that I'm working on this which is not correct 😁 .

There is misunderstanding happening here. @romandev started working on a PR to land napi tsfn node-addon-api impl. I did not do that. I was working on an idea I started as WIP PR (#424), but which might never land. Only for the purpose to have some kind of documentation on things we tried out.

The reason why it looks like I did the tsfn implemention for node-addon-api is simply because the Napi::ThreadSafeFunction impl is missing and I need to use napi tsfn, so my "util" class uses napi tsfn directly. When the PR for this issues has landed, I can rewrite it.

So @romandev please go ahead with your PR on this. I think it would be good to land this soon because I'm also thinking that tsfn is a killer feature, so if you need help or want to hand it over please raise your hand.

This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function*. Fixes nodejs#312.

This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function features. FYI, the test files that included in this PR have come from Node.js repo[1]. They've been rewritten based on C++ and node-addon-api. Fixes nodejs#312. [1] https://github.com/nodejs/node/tree/master/test/node-api/test_threadsafe_function

ghost · 2019-03-29T09:22:18Z

Is this ready for release ?

This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function features. FYI, the test files that included in this PR have come from Node.js repo[1]. They've been rewritten based on C++ and node-addon-api. Fixes nodejs#312. [1] https://github.com/nodejs/node/tree/master/test/node-api/test_threadsafe_function

almoghamdani · 2019-05-10T23:02:02Z

@romandev Do you have an ETA on when this feature will be released?

This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function features. FYI, the test files that included in this PR have come from Node.js repo[1]. They've been rewritten based on C++ and node-addon-api. Fixes nodejs#312. [1] https://github.com/nodejs/node/tree/master/test/node-api/test_threadsafe_function

jackwsun2 · 2019-05-30T02:01:01Z

Implement ThreadSafeFunction class

This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function features. FYI, the test files that included in this PR have come from Node.js repo[1]. They've been rewritten based on C++ and node-addon-api. Fixes nodejs#312. [1] https://github.com/nodejs/node/tree/master/test/node-api/test_threadsafe_function

DuBistKomisch · 2019-07-18T00:09:01Z

any plans on doing a release with this, now that the code and docs are merged?

NickNaso · 2019-07-18T08:40:33Z

Hi @DuBistKomisch,
you can track the tasks fro the new release in this issue #514

ghost · 2019-08-15T06:53:43Z

@romandev Great with this API (!) but are there any examples for how to use the API ?

DuBistKomisch · 2019-08-15T07:31:35Z

@extmchristensen check out https://github.com/nodejs/node-addon-api/blob/master/doc/threadsafe_function.md#example

This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function features. FYI, the test files that included in this PR have come from Node.js repo[1]. They've been rewritten based on C++ and node-addon-api. [1] https://github.com/nodejs/node/tree/e800f9d/test/node-api/test_threadsafe_function PR-URL: nodejs/node-addon-api#442 Fixes: nodejs/node-addon-api#312 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

gabrielschulhof mentioned this issue Oct 8, 2018

napi_threadsafe_function #364

Closed

gabrielschulhof mentioned this issue Dec 18, 2018

how to send data continually to javascript from windows Wave API callback function? #406

Closed

DuBistKomisch mentioned this issue Jan 19, 2019

[WIP]: src: implement NodeThreadScheduler #424

Closed

romandev mentioned this issue Jan 29, 2019

How to have a background thread call back to JS multiple times? #438

Closed

romandev added a commit to romandev/node-addon-api that referenced this issue Feb 5, 2019

[WIP] Implement ThreadSafeFunction class

3d02ab3

This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function*. Fixes nodejs#312.

romandev mentioned this issue Feb 5, 2019

Implement ThreadSafeFunction class #442

Closed

a7ul mentioned this issue Jun 8, 2019

Replace Thread safe async function module nodegui/nodegui#4

Closed

gabrielschulhof closed this as completed in 0a90df2 Jul 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Asynchronous Thread-safe Function Calls #312

Support for Asynchronous Thread-safe Function Calls #312

srirajpaul commented Jul 30, 2018

romandev commented Jul 30, 2018 •

edited

Loading

atoy40 commented Dec 11, 2018

romandev commented Dec 11, 2018

aazavid commented Jan 22, 2019

romandev commented Jan 22, 2019

DaAitch commented Jan 24, 2019

romandev commented Jan 29, 2019

DaAitch commented Jan 29, 2019 •

edited

Loading

ghost commented Mar 29, 2019

almoghamdani commented May 10, 2019

jackwsun2 commented May 30, 2019

DuBistKomisch commented Jul 18, 2019

NickNaso commented Jul 18, 2019

ghost commented Aug 15, 2019

DuBistKomisch commented Aug 15, 2019

Support for Asynchronous Thread-safe Function Calls #312

Support for Asynchronous Thread-safe Function Calls #312

Comments

srirajpaul commented Jul 30, 2018

romandev commented Jul 30, 2018 • edited Loading

atoy40 commented Dec 11, 2018

romandev commented Dec 11, 2018

aazavid commented Jan 22, 2019

romandev commented Jan 22, 2019

DaAitch commented Jan 24, 2019

romandev commented Jan 29, 2019

DaAitch commented Jan 29, 2019 • edited Loading

ghost commented Mar 29, 2019

almoghamdani commented May 10, 2019

jackwsun2 commented May 30, 2019

DuBistKomisch commented Jul 18, 2019

NickNaso commented Jul 18, 2019

ghost commented Aug 15, 2019

DuBistKomisch commented Aug 15, 2019

romandev commented Jul 30, 2018 •

edited

Loading

DaAitch commented Jan 29, 2019 •

edited

Loading