Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding AsyncWorker::OnWorkComplete etc #582

Closed
legendecas opened this issue Oct 31, 2019 · 1 comment
Closed

Allow overriding AsyncWorker::OnWorkComplete etc #582

legendecas opened this issue Oct 31, 2019 · 1 comment

Comments

@legendecas
Copy link
Member

legendecas commented Oct 31, 2019 •
edited
Loading

As for now, AsyncWorker::OnWorkComplete and AsyncWorker::OnExecute was declared as a static private method. We could make a global static function to accept an arbitrary AsyncWorker variant and invoke its own OnWorkComplete and OnExecute to make override possible.

This would be a blocking issue to implement AsyncProgressQueueWorker, which expects a queue cleanup before invoking either OnOk and OnError in OnWorkComplete.
This was referenced Nov 2, 2019
Closed
Closed
@legendecas
Copy link
Member Author

Closed with #589

mhdawson pushed a commit that referenced this issue Mar 18, 2020
@legendecas @mhdawson
src: implement AsyncProgressQueueWorker
ab01844 
PR-URL: #585
Fixes: #582
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: implement AsyncProgressQueueWorker
84af85d 
PR-URL: nodejs/node-addon-api#585
Fixes: nodejs/node-addon-api#582
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: implement AsyncProgressQueueWorker
0258f84 
PR-URL: nodejs/node-addon-api#585
Fixes: nodejs/node-addon-api#582
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: implement AsyncProgressQueueWorker
6da4aed 
PR-URL: nodejs/node-addon-api#585
Fixes: nodejs/node-addon-api#582
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: implement AsyncProgressQueueWorker
4372037 
PR-URL: nodejs/node-addon-api#585
Fixes: nodejs/node-addon-api#582
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@legendecas