Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/threadsafe_function/threadsafe_function_existing_tsfn.js: use assert.strictEqual() #775

Closed
gabrielschulhof opened this issue Jul 25, 2020 · 0 comments
Closed

test/threadsafe_function/threadsafe_function_existing_tsfn.js: use assert.strictEqual() #775

gabrielschulhof opened this issue Jul 25, 2020 · 0 comments
Labels
good first issue

Comments

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jul 25, 2020 •
edited
Loading

Currently it uses assert(typeof ... === 'number') but it would be more expressive in case of failure to use assert.strictEqual(typeof ..., 'number').
@Nishikoh Nishikoh mentioned this issue Jul 25, 2020
Closed
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
test: use assert.strictEqual()
fe758b7 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
test: use assert.strictEqual()
d8f1b04 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
test: use assert.strictEqual()
13faf2d 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
test: use assert.strictEqual()
323f97e 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: use assert.strictEqual()
1 participant
@gabrielschulhof