Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

nodejs / node-addon-api Public

Notifications You must be signed in to change notification settings
Fork 465
Star 2.2k

Code
Issues 10
Pull requests 1
Actions
Projects 1
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security
Insights

Remove `const` from `AsyncProgressWorker::Signal` and `AsyncProgressQueueWorker::Signal`#1086

Closed

JosephusPaye wants to merge 9 commits intonodejs:mainnodejs/node-addon-api:mainfrom JosephusPaye:mainJosephusPaye/node-addon-api:mainCopy head branch name to clipboard

+162-17

Conversation Commits9 (9)Checks Files changed

Commits

Commits on Oct 6, 2021

Remove const from Signal() on async progress workers
JosephusPaye
committed
Remove const from ExecutionProgress param of OnProgress()
JosephusPaye
committed
Add test for AsyncProgressWorker.Signal()
JosephusPaye
committed
Fix test formatting
JosephusPaye
committed

Commits on Oct 11, 2021

Add failing test for AsyncProgressQueueWorker::Signal()
JosephusPaye
committed
Fix formatting
JosephusPaye
committed

Commits on Oct 27, 2021

Apply suggestions from code review

JosephusPaye
and
legendecas
authored
Add const back to ExecutionProgress
JosephusPaye
committed
Add back const to Async*Worker::Execute()
JosephusPaye
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.