Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CleanupHook public #1240

Closed
wants to merge 3 commits into from
Closed

Make CleanupHook public #1240

wants to merge 3 commits into from

Conversation

julianmesa-gitkraken
Copy link
Contributor

@julianmesa-gitkraken julianmesa-gitkraken commented Nov 23, 2022 •
edited
Loading

Make CleanupHook public.
Added default constructor to make easier store the hook in a member class var.
Also fixed a bad #endif position.

This PR fix issue 1238

@julianmesa-gitkraken
Make CleanupHook public
a176445 
Also fixed a bad #endif position
This was referenced Nov 23, 2022
Closed
Merged
legendecas
legendecas reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thank you for working on this!

Would you mind adding a test that verifies the CleanupHook is available to be used as a class member?

@julianmesa-gitkraken
Copy link
Contributor Author

julianmesa-gitkraken commented Nov 30, 2022 •
edited
Loading

Overall LGTM. Thank you for working on this!

Would you mind adding a test that verifies the CleanupHook is available to be used as a class member?

@legendecas Added a very simple test, not sure if it is enough

legendecas
legendecas approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@mhdawson
Copy link
Member

mhdawson commented Dec 2, 2022

Seems like since the docs do identify the type which is returned it should be public so agree this makes sense.

mhdawson
mhdawson approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Dec 2, 2022
@julianmesa-gitkraken @mhdawson
src: make CleanupHook public
39267ba 
PR-URL: #1240
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Also fixed a bad #endif position
@mhdawson
Copy link
Member

mhdawson commented Dec 2, 2022

Landed as 39267ba

@mhdawson mhdawson closed this Dec 2, 2022
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
src: make CleanupHook public
249c0ba 
PR-URL: nodejs/node-addon-api#1240
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Also fixed a bad #endif position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
SemVer-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class Env::CleanupHook should be public
3 participants
@julianmesa-gitkraken @mhdawson @legendecas