chore: Build node-addon-api against X86 #1276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JckXia does this need a rebase, it still seems to be failing after 1275 landed. |
mhdawson
pushed a commit
that referenced
this pull request
Jan 27, 2023
PR-URL: #1276 Reviewed-By: Michael Dawson <midawson@redhat.com
|
landed in ff96948 |
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1276 Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #1275 is merged in. Update our windows CI to build node against X86 based on the observation here. Main source of concern is that this will double the number of runs we will perform for windows CI. But It might be a worthy trade off to avoid issues like #1272