Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call base basic finalizer if none defined #1574

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: call base basic finalizer if none defined #1574

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427ef4d
fix: call base basic finalizer if none defined
KevinEady Sep 4, 2024
72655c6
discard `env` value
KevinEady Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions napi-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5011,6 +5011,10 @@ template <typename T>
inline void ObjectWrap<T>::FinalizeCallback(node_api_nogc_env env,
void* data,
void* /*hint*/) {
// If the child class does not override _any_ Finalize() method, `env` will be
// unused because of the constexpr guards. Explicitly reference it here to
// bypass compiler warnings.
(void)env;
T* instance = static_cast<T*>(data);

// Prevent ~ObjectWrap from calling napi_remove_wrap
Expand Down