-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new build targets for debugging purpose #186
Conversation
@mhdawson, and others PTAL I'm not sure if this patch is useful to you. If you want to always make a clean full build for use in CI tool, this patch might not be useful. But if someone like me uses the command in local environment, doing clean full build every time might be very inefficient. WDYT? |
So far the build time is not a big deal, but that does not mean it won't be later on. We do want full builds in the CI. How about adding a new target which would be test-incremental that could be used when people want an incremental instead of full build ? |
Some days before I worked on a PR and I also find out that |
I personally use ccache to drastically reduce build time. It essentially does an incremental build behind node-gyp's back. |
@mhdawson @gabrielschulhof to recap: I also started with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as "configure build === rebuild" when starting from a clean repo this does not affect CI, and helps out with tinkering locally.
@gabrielschulhof "configure build === rebuild" would go into the CI job, right? |
@mhdawson do you mean that the build should fail if it turns out that configure build !== rebuild? If not, I don't think we need to make any changes to the CI. I believe that as long as the CI runs |
@gabrielschulhof what I was asking is if by adding a command to the CI run we could ensure it does a full rebuild (even without a clean checkout which I don't think jenkins does by default) instead of an incremental rebuild then I'd be comfortable. |
@mhdawson can we simply |
Wouldn't it just be easier to have more build commands, then it's also documented. It would also be nice to test "Debug" with Something like this: {
"scripts": {
"test": "node test",
"pretest": "node-gyp rebuild -C test",
"test:dev": "node test",
"pretest:dev": "node-gyp rebuild -C test --debug",
"test:dev:incremental": "node test",
"pretest:dev:incremental": "node-gyp configure build -C test --debug",
"clean": "node-gyp clean -C test",
"doc": "doxygen doc/Doxyfile"
}
} CI runs
Dev runs:
|
+1 for adding additional targets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this project, we can use the following command to test examples. $ npm test It might be very inefficient, especially, if the number of files increases. So, this patch introduces new build targets for debugging purpose as follows: $ npm run-script dev # Build with --debug option $ npm run-script dev:incremental # Incremental dev build This idea comes from @DaAitch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this project, we can use the following command to test examples. $ npm test It might be very inefficient, especially, if the number of files increases. So, this patch introduces new build targets for debugging purpose as follows: $ npm run-script dev # Build with --debug option $ npm run-script dev:incremental # Incremental dev build This idea comes from @DaAitch. PR-URL: #186 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Landed as fcfc612 |
In this project, we can use the following command to test examples. $ npm test It might be very inefficient, especially, if the number of files increases. So, this patch introduces new build targets for debugging purpose as follows: $ npm run-script dev # Build with --debug option $ npm run-script dev:incremental # Incremental dev build This idea comes from @DaAitch. PR-URL: nodejs/node-addon-api#186 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
In this project, we can use the following command to test examples. $ npm test It might be very inefficient, especially, if the number of files increases. So, this patch introduces new build targets for debugging purpose as follows: $ npm run-script dev # Build with --debug option $ npm run-script dev:incremental # Incremental dev build This idea comes from @DaAitch. PR-URL: nodejs/node-addon-api#186 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
In this project, we can use the following command to test examples. $ npm test It might be very inefficient, especially, if the number of files increases. So, this patch introduces new build targets for debugging purpose as follows: $ npm run-script dev # Build with --debug option $ npm run-script dev:incremental # Incremental dev build This idea comes from @DaAitch. PR-URL: nodejs/node-addon-api#186 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
In this project, we can use the following command to test examples. $ npm test It might be very inefficient, especially, if the number of files increases. So, this patch introduces new build targets for debugging purpose as follows: $ npm run-script dev # Build with --debug option $ npm run-script dev:incremental # Incremental dev build This idea comes from @DaAitch. PR-URL: nodejs/node-addon-api#186 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
In this project, we can use the following command to test examples.
$ npm test
It might be very inefficient, especially, if the number of files
increases. So, this patch introduces new build targets for debugging
purpose as follows:
This idea comes from @DaAitch.