Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused CallbackScope member #391

Closed
wants to merge 1 commit into from
Closed

src: remove unused CallbackScope member #391

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

NickNaso
NickNaso approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

romandev
romandev approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso NickNaso mentioned this pull request Nov 13, 2018
Closed
2 tasks
mhdawson pushed a commit that referenced this pull request Nov 13, 2018
@mhdawson
src: remove unused CallbackScope member
e7cd292 
PR-URL: #391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
@mhdawson
Copy link
Member

Landed as e7cd292

@mhdawson mhdawson closed this Nov 13, 2018
@gabrielschulhof gabrielschulhof deleted the remove-unused-param branch December 27, 2018 18:01
@gabrielschulhof gabrielschulhof restored the remove-unused-param branch December 28, 2018 20:27
@gabrielschulhof gabrielschulhof deleted the remove-unused-param branch February 13, 2019 23:28
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
src: remove unused CallbackScope member
4fceb6d 
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
src: remove unused CallbackScope member
7f26541 
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
src: remove unused CallbackScope member
d51893d 
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
src: remove unused CallbackScope member
a10a1b6 
PR-URL: nodejs/node-addon-api#391
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Reviewed-By: Jinho Bang <zino@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@romandev romandev romandev approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielschulhof @mhdawson @NickNaso @romandev