Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CMake.js doc to current best practices #558

Closed
wants to merge 2 commits into from
Closed

Update the CMake.js doc to current best practices #558

wants to merge 2 commits into from

Conversation

jschlight
Copy link
Contributor

@jschlight jschlight commented Oct 7, 2019 •
edited
Loading

This PR improves the documentation for CMake.js to accompany to the recent CMake.js example project.

Fixes nodejs/abi-stable-node#381

@jschlight jschlight changed the title Updates the CMake.js doc to current best practices Update the CMake.js doc to current best practices Oct 7, 2019
@jschlight
Copy link
Contributor Author

See nodejs/abi-stable-node#381.

NickNaso
NickNaso reviewed Oct 7, 2019
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only some comments.

doc/cmake-js.md Outdated Show resolved Hide resolved
doc/cmake-js.md Show resolved Hide resolved
mhdawson
mhdawson approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso NickNaso mentioned this pull request Oct 22, 2019
Closed
15 tasks
gabrielschulhof
gabrielschulhof approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to move the links to the bottom of the document with

...
... blah blah blah [some text][] blah blah blah ...
...
[some text]: https://example.com/some-text

mhdawson pushed a commit that referenced this pull request Oct 23, 2019
@jschlight @mhdawson
doc: updates Make.js doc to current best practices
e9a4bcd 
PR-URL: #558
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@mhdawson
Copy link
Member

Landed as: e9a4bcd

@mhdawson mhdawson closed this Oct 23, 2019
@jschlight jschlight deleted the cmake-js-doc branch October 24, 2019 19:47
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
doc: updates Make.js doc to current best practices
11a1202 
PR-URL: nodejs/node-addon-api#558
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
doc: updates Make.js doc to current best practices
bfad5c2 
PR-URL: nodejs/node-addon-api#558
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
doc: updates Make.js doc to current best practices
356494b 
PR-URL: nodejs/node-addon-api#558
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
doc: updates Make.js doc to current best practices
1c92948 
PR-URL: nodejs/node-addon-api#558
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building addons with cmake
4 participants
@jschlight @mhdawson @NickNaso @gabrielschulhof