object: add templated property descriptors #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
force-pushed
the
templated-property-descriptors
branch
from
8ec7f34
to
70fac85
Compare
gabrielschulhof
changed the title
NickNaso
reviewed
Dec 3, 2019
gabrielschulhof
force-pushed
the
templated-property-descriptors
branch
from
70fac85
to
6e45426
Compare
tniessen
approved these changes
Dec 4, 2019
|
CI:
|
gabrielschulhof
force-pushed
the
templated-property-descriptors
branch
from
6e45426
to
899a12a
Compare
Add static methods to `PropertyDescriptor` that allows the definition of accessors where the getter/setter is specified as a template parameter rather than a function parameter. This allows us to avoid heap-allocating callback data.
gabrielschulhof
force-pushed
the
templated-property-descriptors
branch
from
66a07c1
to
189176b
Compare
|
Fixed Windows compilation issues. |
|
New CI:
Looks like there is a Win10 issue. |
legendecas
approved these changes
Dec 5, 2019
|
Trying a build against v14.x: https://ci.nodejs.org/job/node-test-node-addon-api-new/1222/ |
|
OK, since that seemed to work, let's see how low we can go 🙂
|
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 5, 2019
Add static methods to `PropertyDescriptor` that allows the definition of accessors where the getter/setter is specified as a template parameter rather than a function parameter. This allows us to avoid heap-allocating callback data. PR-URL: #610 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed in cfa71b6. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Add static methods to `PropertyDescriptor` that allows the definition of accessors where the getter/setter is specified as a template parameter rather than a function parameter. This allows us to avoid heap-allocating callback data. PR-URL: nodejs/node-addon-api#610 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Add static methods to `PropertyDescriptor` that allows the definition of accessors where the getter/setter is specified as a template parameter rather than a function parameter. This allows us to avoid heap-allocating callback data. PR-URL: nodejs/node-addon-api#610 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Add static methods to `PropertyDescriptor` that allows the definition of accessors where the getter/setter is specified as a template parameter rather than a function parameter. This allows us to avoid heap-allocating callback data. PR-URL: nodejs/node-addon-api#610 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Add static methods to `PropertyDescriptor` that allows the definition of accessors where the getter/setter is specified as a template parameter rather than a function parameter. This allows us to avoid heap-allocating callback data. PR-URL: nodejs/node-addon-api#610 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.