Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix std::string encoding #619

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix std::string encoding #619

merged 1 commit into from
Dec 5, 2019

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Dec 2, 2019

  1. "ANSI" is misleading and not a good description of any string encoding. It is commonly used to refer to "Windows code pages" such as Windows-125x, but these code pages have never been standardized by ANSI.
  2. It is wrong, we treat std::string as UTF8.

@tniessen
Fix std::string encoding
9da57e1 
1. "ANSI" is misleading and not a good description of any string
   encoding. It is commonly used to refer to "Windows code pages"
   such as Windows-125x, but these code pages have never been
   standardized by ANSI.
2. It is wrong, we treat std::string as UTF8.
@tniessen tniessen added the doc label Dec 2, 2019
NickNaso
NickNaso approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KevinEady
KevinEady approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 3acc4b3 into nodejs:master Dec 5, 2019
@tniessen tniessen deleted the fix-string-encoding branch January 23, 2020 03:47
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
Fix std::string encoding (#619)
b19dac2 
1. "ANSI" is misleading and not a good description of any string
   encoding. It is commonly used to refer to "Windows code pages"
   such as Windows-125x, but these code pages have never been
   standardized by ANSI.
2. It is wrong, we treat std::string as UTF8.

PR-URL: nodejs/node-addon-api#619
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
Fix std::string encoding (#619)
b7a4507 
1. "ANSI" is misleading and not a good description of any string
   encoding. It is commonly used to refer to "Windows code pages"
   such as Windows-125x, but these code pages have never been
   standardized by ANSI.
2. It is wrong, we treat std::string as UTF8.

PR-URL: nodejs/node-addon-api#619
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
Fix std::string encoding (#619)
75cf202 
1. "ANSI" is misleading and not a good description of any string
   encoding. It is commonly used to refer to "Windows code pages"
   such as Windows-125x, but these code pages have never been
   standardized by ANSI.
2. It is wrong, we treat std::string as UTF8.

PR-URL: nodejs/node-addon-api#619
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Fix std::string encoding (#619)
9110adb 
1. "ANSI" is misleading and not a good description of any string
   encoding. It is commonly used to refer to "Windows code pages"
   such as Windows-125x, but these code pages have never been
   standardized by ANSI.
2. It is wrong, we treat std::string as UTF8.

PR-URL: nodejs/node-addon-api#619
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@KevinEady KevinEady KevinEady approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @NickNaso @KevinEady @mhdawson