Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove N-API implementation and v8.x support #643

Closed
wants to merge 1 commit into from
Closed

remove N-API implementation and v8.x support #643

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Jan 1, 2020 •
edited
Loading

Remove the files associated with the external implementation of N-API
and the v8.x Travis CI testing. This move is possible because of v8.x
EOL, which means that all supported versions of Node.js now have an
internal implementation of N-API.

Fixes: #463
Fixes: #509

@gabrielschulhof gabrielschulhof changed the title remove N-API implementation remove N-API implementation and v8.x support Jan 1, 2020
@legendecas
Copy link
Member

This can fix #640 since it removes Node.js v6 support.

@gabrielschulhof
Copy link
Contributor Author

@legendecas thanks! I updated the commit message to reflect that.

@gabrielschulhof gabrielschulhof mentioned this pull request Jan 2, 2020
Closed
NickNaso
NickNaso reviewed Jan 3, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think to move node_api.gyp and nothing.c on the root folder and completely remove the src folder? Maybe now we could change the name of node_api.gyp in nothing.gyp and then use nothing.gyp:nothing on index.js.

@gabrielschulhof
Copy link
Contributor Author

@NickNaso we should also update the docs to remove 'dependencies': [ '<!(...)'].

@NickNaso
Copy link
Member

NickNaso commented Jan 3, 2020

@NickNaso we should also update the docs to remove 'dependencies': [ '<!(...)'].

Yes, in this way the new end-user will not include the dependencies in their binding.gyp, but the old project will continue to work because under the hood we will continue to provide / export the dependencies.

remove N-API implementation, v6.x and v8.x support
88d0032 
Remove the followings:

* the files associated with the external implementation of N-API
* Travis CI jobs for v8.x and v6.x
* documentation instructing users to add the external N-API
  implementation to their dependencies.
* conversion tool code that adds the external N-API implementation as a
  dependency to the user's addon.

This move is possible because of v8.x EOL, which means that all
supported versions of Node.js now have an internal implementation of
N-API.

Fixes: nodejs#463
Fixes: nodejs#509
Fixes: nodejs#640
@gabrielschulhof
Copy link
Contributor Author

@tniessen @legendecas @NickNaso I updated the PR to include a doc update removing instructions for adding the external N-API implementation to an addon's dependencies. Could you please take another look?

NickNaso
NickNaso approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof
Copy link
Contributor Author

CI:

Version Job Status
v14.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1553/ ✗
https://ci.nodejs.org/job/node-test-node-addon-api-new/1556/ ✗
https://ci.nodejs.org/job/node-test-node-addon-api-new/1557/ ✓
v12.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1554/ ✗
https://ci.nodejs.org/job/node-test-node-addon-api-new/1558/ ✓
v10.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1555/ ✗
https://ci.nodejs.org/job/node-test-node-addon-api-new/1559/ ✓

gabrielschulhof pushed a commit that referenced this pull request Jan 7, 2020
remove N-API implementation, v6.x and v8.x support
9af69da 
Remove the followings:

* the files associated with the external implementation of N-API
* Travis CI jobs for v8.x and v6.x
* documentation instructing users to add the external N-API
  implementation to their dependencies.
* conversion tool code that adds the external N-API implementation as a
  dependency to the user's addon.

This move is possible because of v8.x EOL, which means that all
supported versions of Node.js now have an internal implementation of
N-API.

Fixes: #463
Fixes: #509
Fixes: #640
PR-URL: #643
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@gabrielschulhof
Copy link
Contributor Author

Landed in 9af69da.

@addaleax
Copy link
Member

@gabrielschulhof Just to make sure, this will be released in a new semver-major release, right?

@gabrielschulhof
Copy link
Contributor Author

@addaleax good point! It definitely should be semver-major.

@gabrielschulhof gabrielschulhof mentioned this pull request Jan 10, 2020
Closed
addaleax added a commit to addaleax/node-api that referenced this pull request Jan 24, 2020
@addaleax
gyp: fix gypfile name in index.js
878d97d 
Refs: nodejs#643
@addaleax addaleax mentioned this pull request Jan 24, 2020
Closed
@gabrielschulhof gabrielschulhof deleted the remove-implementation branch January 29, 2020 18:07
gabrielschulhof pushed a commit that referenced this pull request Jan 30, 2020
@addaleax
gyp: fix gypfile name in index.js
7ac6e21 
Refs: #643
PR-URL: #658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cinderblock cinderblock mentioned this pull request Jan 21, 2021
Closed
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
remove N-API implementation, v6.x and v8.x support
17dfdfe 
Remove the followings:

* the files associated with the external implementation of N-API
* Travis CI jobs for v8.x and v6.x
* documentation instructing users to add the external N-API
  implementation to their dependencies.
* conversion tool code that adds the external N-API implementation as a
  dependency to the user's addon.

This move is possible because of v8.x EOL, which means that all
supported versions of Node.js now have an internal implementation of
N-API.

Fixes: nodejs/node-addon-api#463
Fixes: nodejs/node-addon-api#509
Fixes: nodejs/node-addon-api#640
PR-URL: nodejs/node-addon-api#643
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
gyp: fix gypfile name in index.js
9ddb06e 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
remove N-API implementation, v6.x and v8.x support
46e93a1 
Remove the followings:

* the files associated with the external implementation of N-API
* Travis CI jobs for v8.x and v6.x
* documentation instructing users to add the external N-API
  implementation to their dependencies.
* conversion tool code that adds the external N-API implementation as a
  dependency to the user's addon.

This move is possible because of v8.x EOL, which means that all
supported versions of Node.js now have an internal implementation of
N-API.

Fixes: nodejs/node-addon-api#463
Fixes: nodejs/node-addon-api#509
Fixes: nodejs/node-addon-api#640
PR-URL: nodejs/node-addon-api#643
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
gyp: fix gypfile name in index.js
c20af78 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
remove N-API implementation, v6.x and v8.x support
78e802f 
Remove the followings:

* the files associated with the external implementation of N-API
* Travis CI jobs for v8.x and v6.x
* documentation instructing users to add the external N-API
  implementation to their dependencies.
* conversion tool code that adds the external N-API implementation as a
  dependency to the user's addon.

This move is possible because of v8.x EOL, which means that all
supported versions of Node.js now have an internal implementation of
N-API.

Fixes: nodejs/node-addon-api#463
Fixes: nodejs/node-addon-api#509
Fixes: nodejs/node-addon-api#640
PR-URL: nodejs/node-addon-api#643
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
gyp: fix gypfile name in index.js
9a311f0 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
remove N-API implementation, v6.x and v8.x support
65a8044 
Remove the followings:

* the files associated with the external implementation of N-API
* Travis CI jobs for v8.x and v6.x
* documentation instructing users to add the external N-API
  implementation to their dependencies.
* conversion tool code that adds the external N-API implementation as a
  dependency to the user's addon.

This move is possible because of v8.x EOL, which means that all
supported versions of Node.js now have an internal implementation of
N-API.

Fixes: nodejs/node-addon-api#463
Fixes: nodejs/node-addon-api#509
Fixes: nodejs/node-addon-api#640
PR-URL: nodejs/node-addon-api#643
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
gyp: fix gypfile name in index.js
928b339 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

@tniessen tniessen tniessen approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update node_api modules at src/ with threadsafe functionality Bundles node_api.h is outdated
6 participants
@gabrielschulhof @legendecas @NickNaso @addaleax @tniessen @mhdawson