Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading sentence #847

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Remove misleading sentence #847

merged 1 commit into from
Dec 7, 2020

Conversation

seishun
Copy link
Contributor

@seishun seishun commented Dec 2, 2020

The address-of operator is required for all class members.

@seishun
Remove misleading sentence
07fbbce 
The address-of operator is required for all class members.
NickNaso
NickNaso approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso NickNaso mentioned this pull request Dec 4, 2020
Closed
9 tasks
mhdawson
mhdawson approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 4bb680d into nodejs:master Dec 7, 2020
@seishun seishun deleted the patch-1 branch December 7, 2020 19:03
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
Remove misleading sentence (#847)
e5eb5d2 
The address-of operator is required for all class members.

PR-URL: nodejs/node-addon-api#847
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
Remove misleading sentence (#847)
10e785a 
The address-of operator is required for all class members.

PR-URL: nodejs/node-addon-api#847
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
Remove misleading sentence (#847)
73a909b 
The address-of operator is required for all class members.

PR-URL: nodejs/node-addon-api#847
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Remove misleading sentence (#847)
9331c23 
The address-of operator is required for all class members.

PR-URL: nodejs/node-addon-api#847
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seishun @NickNaso @gabrielschulhof @mhdawson