Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: return bool on object freeze and seal #991

Merged
merged 1 commit into from
May 7, 2021

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented May 5, 2021

These operations can call into JavaScript by using Proxy handlers,
hence JavaScript exceptions might pending at the end of the operations.

This is not a breaking change.

These operations can calling into JavaScript by using Proxy handlers,
hence JavaScript exceptions might pending on the end of the operations.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit 410cf6a into nodejs:main May 7, 2021
@legendecas legendecas deleted the object-free-seal branch May 7, 2021 03:35
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Sep 23, 2021
These operations can call into JavaScript by using Proxy handlers,
hence JavaScript exceptions might pending at the end of the operations.
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Oct 15, 2021
These operations can call into JavaScript by using Proxy handlers,
hence JavaScript exceptions might pending at the end of the operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants