Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial website #146

Merged
merged 7 commits into from
Jul 20, 2020
Merged

Tutorial website #146

merged 7 commits into from
Jul 20, 2020

Conversation

jschlight
Copy link
Contributor

@jschlight jschlight commented Jul 10, 2020

This PR adds a new website directory containing a Gatsby site.

The primary file that needs to be reviewed is the README.md file in the website directory.

The contents of the website are in the website/docs directory. The website/src and website/static directories contain the Gatsby files necessary to generate the website. The website/README.md has some orientation information including installing Gatsby and viewing the site on your development system.

A current site, generated by Gatsby from this PR and hosted by GitHub Pages can be viewed here:

https://jschlight.github.io/node-addon-examples

The current objective is to simply get the site ported into the examples repo. The contents of the site need a review we can perform after the site is live on GitHub Pages.

See nodejs/abi-stable-node#391

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jschlight confirmed that the only files he did not create were from the Gatsby theme he used which was MIT licenced.

@jschlight jschlight merged commit 4d4dced into nodejs:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants