Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: add TypedThreadSafeFunction #185

Merged
merged 3 commits into from
Jun 22, 2021
Merged

example: add TypedThreadSafeFunction #185

merged 3 commits into from
Jun 22, 2021

Conversation

KevinEady
Copy link
Contributor

This adds the TypedThreadSafeFunction example from the documentation.

@KevinEady KevinEady marked this pull request as draft June 3, 2021 20:08
@KevinEady
Copy link
Contributor Author

This replicates the gcc-11 problem with c++20 listed at nodejs/node-addon-api#1007

mhdawson
mhdawson approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinEady KevinEady force-pushed the add-typed-tsfn-example branch from 33a7e1a to 665034c Compare June 21, 2021 22:24
@KevinEady KevinEady marked this pull request as ready for review June 21, 2021 22:25
@KevinEady
Copy link
Contributor Author

Hi @mhdawson and team,

This is ready for review

mhdawson
mhdawson approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again :)

@mhdawson mhdawson merged commit 39faeb2 into main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinEady @legendecas @mhdawson