feat(no-release): add conditional support in #if
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have merged this branch into my local fork, ran the Sync Headers job manually, and got this PR: KevinEady#73 which removes the experimental conditional. I marked this change as |
KevinEady
force-pushed
the
add-conditional-if-support
branch
from
391b3d2 to
adce36c
Compare
|
We discussed today in the team meeting, the concensus seemed to be to land this and we'll discuss the inclusion or not of experimental as a follow on discussion. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
acornto create an AST of the condition, then visit the AST to return a result of the conditional:true,false, orundefined(when a result cannot be guaranteed).Fixes: #51