doc: update README to test PR squashing #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs/node#39128 Reviewed-By: Mary Marchini <oss@mmarchini.me>
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: nodejs/node#40436 Refs: nodejs/node-core-utils#572 PR-URL: nodejs/node#40577
This reverts commit 7abb10a.
aduh95
approved these changes
Oct 31, 2021
Commit Queue failed- Loading data for nodejs/node-auto-test/pull/40 ✔ Done loading data for nodejs/node-auto-test/pull/40 ----------------------------------- PR info ------------------------------------ Title doc: update README to test PR squashing (#40) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95-test-account:test-pr-squashing -> nodejs:main Labels fast-track Commits 1 - doc: update README to test PR squashing Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node-auto-test/pull/40 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node-auto-test/pull/40 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 31 Oct 2021 10:02:34 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node-auto-test/pull/40#pullrequestreview-793688411 ℹ This PR is being fast-tracked ✖ This PR needs to wait 167 more hours to land (or 47 hours if there is one more approval) ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node-auto-test/node-auto-test/.ncuhttps://github.com/nodejs/node-auto-test/actions/runs/1404418999 |
|
@targos can you approve this PR so it can be fast-tracked please? |
targos
approved these changes
Oct 31, 2021
Commit Queue failed- Loading data for nodejs/node-auto-test/pull/40 ✔ Done loading data for nodejs/node-auto-test/pull/40 ----------------------------------- PR info ------------------------------------ Title doc: update README to test PR squashing (#40) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95-test-account:test-pr-squashing -> nodejs:main Labels fast-track Commits 1 - doc: update README to test PR squashing Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node-auto-test/pull/40 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node-auto-test/pull/40 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 31 Oct 2021 10:02:34 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node-auto-test/pull/40#pullrequestreview-793688411 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node-auto-test/pull/40#pullrequestreview-793691367 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node-auto-test/node-auto-test/.ncuhttps://github.com/nodejs/node-auto-test/actions/runs/1404487166 |
Maybe we should try to contact GitHub's support about this. It happens sometimes that the API reports pending checks that don't seem to exist. |
Maybe we could also update ncu to ignore those ghost checks. Here's the result of {
"data": {
"repository": {
"pullRequest": {
"commits": {
"nodes": [
{
"commit": {
"checkSuites": {
"nodes": [
{
"id": "CS_kwDOBnE3X877E5v3",
"url": "https://github.com/nodejs/node-auto-test/commit/f5b0a228f2265278d1a79bfe4c2affda1d6c2506/checks?check_suite_id=4212366327",
"conclusion": null,
"status": "QUEUED"
},
{
"id": "CS_kwDOBnE3X877E6TL",
"url": "https://github.com/nodejs/node-auto-test/commit/f5b0a228f2265278d1a79bfe4c2affda1d6c2506/checks?check_suite_id=4212368587",
"conclusion": "SUCCESS",
"status": "COMPLETED"
}
]
},
"status": null
}
}
]
}
}
}
}
} |
|
How do we know it's a ghost check? |
Not sure, but if the
|
I think it's |
|
I created a support ticket. |
panva
force-pushed
the
main
branch
29 times, most recently
from
6fb17d1 to
c8e2f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test.