Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Intl issues on Mac and Linux #567

Open
kfarnung opened this issue Jul 10, 2018 · 1 comment
Open

Intl issues on Mac and Linux #567

kfarnung opened this issue Jul 10, 2018 · 1 comment
Assignees
@jackhorton

Comments

@kfarnung
Copy link
Contributor

  • Version: master
  • Platform: mac, linux
  • Subsystem: icu

Recent upstream changes have caused issues with global.Intl on Mac and Linux. cctest is starting to fail with crashes:

14:35:48 FATAL ERROR: v8::ToLocalChecked: Empty MaybeLocal.
14:35:48 TypeError: Intl is not available.
14:35:48    at Anonymous function (:7:20)
14:35:48    at Global code (:5:2)
14:35:49 make[1]: *** [Makefile:458: test-ci] Aborted (core dumped)
@kfarnung
Copy link
Contributor Author

/cc @MSLaguana @jackhorton

@kfarnung kfarnung mentioned this issue Jul 10, 2018
Merged
2 tasks
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Jul 10, 2018
@kfarnung
src,test: disable per_context.js shim
d988562 
The `Intl` usage in the the shim is causing issues in ChakraCore on
Linux and Mac. Since we don't necessarily need the `Atomics.notify`
shim code either the simplest solution is to remove the shim
completely for ChakraCore.

Refs: nodejs#565
Refs: nodejs#567
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Jul 10, 2018
@kfarnung
src,test: disable per_context.js shim
4236937 
The `Intl` usage in the the shim is causing issues in ChakraCore on
Linux and Mac. Since we don't necessarily need the `Atomics.notify`
shim code either the simplest solution is to remove the shim
completely for ChakraCore.

Refs: nodejs#565
Refs: nodejs#567
PR-URL: nodejs#566
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Jul 10, 2018
@kfarnung
src,test: disable per_context.js shim
f5d29d5 
The `Intl` usage in the the shim is causing issues in ChakraCore on
Linux and Mac. Since we don't necessarily need the `Atomics.notify`
shim code either the simplest solution is to remove the shim
completely for ChakraCore.

Refs: nodejs#565
Refs: nodejs#567
PR-URL: nodejs#566
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
@jackhorton jackhorton self-assigned this Jul 12, 2018
This was referenced Sep 14, 2018
Open
Merged
kfarnung added a commit to kfarnung/ChakraCore that referenced this issue Sep 18, 2018
@kfarnung
Intl should only early OOM for full builds
c27eb77 
This currently causes a problem in node where `cctest` fails when
trying to access the Intl object to check for a property.

Refs: nodejs/node-chakracore#567
chakrabot pushed a commit to chakra-core/ChakraCore that referenced this issue Sep 18, 2018
@kfarnung
[MERGE #5708 @kfarnung] Intl should only early OOM for full builds
100d06a 
Merge pull request #5708 from kfarnung:intl

This currently causes a problem in node where `cctest` fails when
trying to access the Intl object to check for a property.

Refs: nodejs/node-chakracore#567
chakrabot pushed a commit that referenced this issue Sep 18, 2018
@kfarnung @chakrabot
deps: update ChakraCore to chakra-core/ChakraCore@100d06a7c1
7c62efa 
[MERGE #5708 @kfarnung] Intl should only early OOM for full builds

Merge pull request #5708 from kfarnung:intl

This currently causes a problem in node where `cctest` fails when
trying to access the Intl object to check for a property.

Refs: #567

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Sep 18, 2018
@kfarnung
src,test: enable per_context.js shim
77d93e0 
This reverts commit f5d29d5. It also
updates the shim to use shim `wake` using `notify`.

Refs: nodejs#565
Refs: nodejs#567
@kfarnung kfarnung mentioned this issue Sep 18, 2018
Merged
4 tasks
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Sep 18, 2018
@kfarnung
src,test: enable per_context.js shim
36aaa95 
This reverts commit f5d29d5. It also
updates the shim to use shim `wake` using `notify`.

Refs: nodejs#565
Refs: nodejs#567
Refs: nodejs/node#22844
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Sep 18, 2018
@kfarnung
src,test: enable per_context.js shim
b8de4df 
This reverts commit f5d29d5.

PR-URL: nodejs#600
Refs: nodejs#565
Refs: nodejs#567
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Sep 20, 2018
@kfarnung
src,test: enable per_context.js shim
e198aca 
This reverts commit f5d29d5.

PR-URL: nodejs#600
Refs: nodejs#565
Refs: nodejs#567
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jackhorton jackhorton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfarnung @jackhorton