fix(ncu-ci): fix missing await causing all CI requests to be reject…

…ed (#799)
nodejs · Apr 24, 2024 · 7fc2f9d · 7fc2f9d
1 parent 78ef163
commit 7fc2f9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/ci/run_ci.js b/lib/ci/run_ci.js
@@ -26,7 +26,9 @@ export class RunPRJob {
     this.prData = new PRData({ prid, owner, repo }, cli, request);
     this.certifySafe =
       certifySafe ||
-      new PRChecker(cli, this.prData, request, {}).checkCommitsAfterReview();
+      Promise.all([this.prData.getReviews(), this.prData.getPR()]).then(() =>
+        new PRChecker(cli, this.prData, request, {}).checkCommitsAfterReview()
+      );
   }
 
   async getCrumb() {
@@ -68,7 +70,7 @@ export class RunPRJob {
   async start() {
     const { cli, certifySafe } = this;
 
-    if (!certifySafe) {
+    if (!(await certifySafe)) {
       cli.error('Refusing to run CI on potentially unsafe PR');
       return false;
     }

diff --git a/test/unit/ci_start.test.js b/test/unit/ci_start.test.js
@@ -124,7 +124,7 @@ describe('Jenkins', () => {
         const cli = new TestCLI();
 
         sinon.replace(PRChecker.prototype, 'checkCommitsAfterReview',
-          sinon.fake.returns(certifySafe));
+          sinon.fake.returns(Promise.resolve(certifySafe)));
 
         const request = {
           gql: sinon.stub().returns({