bin: custom git commands #106

joyeecheung · 2017-11-11T04:47:19Z

This was #98 , opening a new PR because the repo has been transferred so I need to update the branch of my fork instead.

codecov · 2017-11-11T04:49:13Z

Codecov Report

Merging #106 into master will decrease coverage by 2.19%.
The diff coverage is 7.14%.

@@            Coverage Diff            @@
##           master     #106     +/-   ##
=========================================
- Coverage   98.05%   95.86%   -2.2%     
=========================================
  Files          15       15             
  Lines         567      581     +14     
=========================================
+ Hits          556      557      +1     
- Misses         11       24     +13

Impacted Files	Coverage Δ
lib/cli.js	`73.77% <7.14%> (-19.85%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc9e3a...ad7a7a7. Read the comment docs.

priyank-p · 2017-11-15T16:24:08Z

bin/git/git-node-apply

+const paths = require('./../../lib/paths');
+const { run, runAsync } = require('../../lib/run');
+const fs = require('fs');
+const CLI = require('../../lib/CLI');


I think this should be ../../lib/cli.

joyeecheung · 2017-11-15T16:32:42Z

Note that this is still WIP, I would still need to find some time to port the rest of the bash scripts to Node.js scripts. Although I have been using this fork locally to land stuff anyways.

priyank-p · 2017-11-15T17:15:25Z

I totally did not mean to hit approve meant to comment...

priyank-p · 2017-11-17T16:18:25Z

@joyeecheung tried to port bash scripts to node-script and this is currently what i have.
https://gist.github.com/cPhost/dec7ce68a09907791ce99147feb618e9

(I this help great! 👍 )

joyeecheung · 2017-11-17T20:58:22Z

@cPhost Thanks, but the porting is not really what's blocking me right now...The more I use it, the more I prefer the git node land --continue concept (I don't really like to remember all those sub commands, even if they are devised by myself. Also it's kinda annoying that I have to paste the PR id multiple times), so the commands kinda need a rework to mimic a git rebase session.

priyank-p · 2017-11-17T21:58:15Z

Also after landing this before publishing to npm, we need to ensure the Windows compatibility.

priyank-p · 2017-11-20T12:49:43Z

After thinking about sub commands i think we should have then and and implement single land script that does all the things at once with the subcommands.

joyeecheung · 2017-11-21T16:04:07Z

Recording of working prototype: https://asciinema.org/a/6i3gFDSAr7L6fYPSEaMrW0asO

joyeecheung · 2018-01-15T13:41:16Z

I've been using it for about two months now and it seems to be working pretty well. There are still a few things that need to be addressed:

core-validate-commit must be installed
core-validate-commit still complains about commit titles > 50 char so git node land --final fails from time to time. (should be fixed by warn for 50 < title <= 72 core-validate-commit#18)
Needs some docs
Needs some tests (would be a bit trickier to set up since it involves a lot of git operations)

I think when I finished 3 this should be ready to land on master.

joyeecheung · 2018-01-17T01:38:13Z

Docs done. Demos:

Landing multiple commits: https://asciinema.org/a/148627
Landing one commit: https://asciinema.org/a/157445

This should be ready to merge.

priyank-p · 2018-01-17T01:43:13Z

This Looks good to me :)

joyeecheung · 2018-01-17T01:43:46Z

I am going to merge this and release a new version. Let's see how it works in the wild.

joyeecheung changed the title ~~[WIP] bin: custom git commands #98~~ [WIP] bin: custom git commands Nov 11, 2017

Tiriel approved these changes Nov 11, 2017

View reviewed changes

joyeecheung added the Work In Progress PR's that are in progress label Nov 12, 2017

priyank-p approved these changes Nov 15, 2017

View reviewed changes

joyeecheung force-pushed the git-cmd branch from f72b58c to 44d1c32 Compare November 16, 2017 06:11

joyeecheung mentioned this pull request Nov 16, 2017

restructure the directory layout #113

Merged

joyeecheung force-pushed the git-cmd branch 2 times, most recently from 03da45f to 6c578ef Compare November 20, 2017 13:37

joyeecheung mentioned this pull request Nov 21, 2017

Work out PR number for head branch #119

Closed

joyeecheung force-pushed the git-cmd branch from 21dfff3 to c7b81d5 Compare November 30, 2017 13:45

joyeecheung force-pushed the git-cmd branch 3 times, most recently from 9ed39bd to f99e6f4 Compare January 11, 2018 18:46

joyeecheung mentioned this pull request Jan 11, 2018

config: implement ncu-config #139

Merged

joyeecheung force-pushed the git-cmd branch from f99e6f4 to 6b0661b Compare January 12, 2018 13:32

joyeecheung changed the title ~~[WIP] bin: custom git commands~~ bin: custom git commands Jan 15, 2018

joyeecheung added 2 commits January 17, 2018 09:32

bin: custom git command git node

23d0194

git: abstract landing session over session

7042403

joyeecheung force-pushed the git-cmd branch from 6b0661b to 9d9e720 Compare January 17, 2018 01:32

joyeecheung removed the Work In Progress PR's that are in progress label Jan 17, 2018

joyeecheung force-pushed the git-cmd branch from 9d9e720 to 6a255f0 Compare January 17, 2018 01:34

joyeecheung force-pushed the git-cmd branch 2 times, most recently from a4618aa to 4752dee Compare January 17, 2018 01:36

joyeecheung force-pushed the git-cmd branch from 4752dee to a32429c Compare January 17, 2018 01:42

doc: document the git command

ad7a7a7

joyeecheung force-pushed the git-cmd branch from a32429c to ad7a7a7 Compare January 17, 2018 01:43

joyeecheung merged commit 8a0e114 into nodejs:master Jan 17, 2018

joyeecheung mentioned this pull request Jan 18, 2018

New tool for analytics on contributor activity #143

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bin: custom git commands #106

bin: custom git commands #106

joyeecheung commented Nov 11, 2017

codecov bot commented Nov 11, 2017 •

edited

Loading

priyank-p Nov 15, 2017

joyeecheung commented Nov 15, 2017

priyank-p commented Nov 15, 2017

priyank-p commented Nov 17, 2017

joyeecheung commented Nov 17, 2017 •

edited

Loading

priyank-p commented Nov 17, 2017

priyank-p commented Nov 20, 2017

joyeecheung commented Nov 21, 2017

joyeecheung commented Jan 15, 2018 •

edited

Loading

joyeecheung commented Jan 17, 2018

priyank-p commented Jan 17, 2018

joyeecheung commented Jan 17, 2018

bin: custom git commands #106

bin: custom git commands #106

Conversation

joyeecheung commented Nov 11, 2017

codecov bot commented Nov 11, 2017 • edited Loading

Codecov Report

priyank-p Nov 15, 2017

Choose a reason for hiding this comment

joyeecheung commented Nov 15, 2017

priyank-p commented Nov 15, 2017

priyank-p commented Nov 17, 2017

joyeecheung commented Nov 17, 2017 • edited Loading

priyank-p commented Nov 17, 2017

priyank-p commented Nov 20, 2017

joyeecheung commented Nov 21, 2017

joyeecheung commented Jan 15, 2018 • edited Loading

joyeecheung commented Jan 17, 2018

priyank-p commented Jan 17, 2018

joyeecheung commented Jan 17, 2018

codecov bot commented Nov 11, 2017 •

edited

Loading

joyeecheung commented Nov 17, 2017 •

edited

Loading

joyeecheung commented Jan 15, 2018 •

edited

Loading