land: add non-interactive mode #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchini
commented
Oct 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 75.52% 75.66% +0.13%
==========================================
Files 21 21
Lines 1418 1422 +4
==========================================
+ Hits 1071 1076 +5
+ Misses 347 346 -1
Continue to review full report at Codecov.
|
|
I'll try to add some tests. |
joyeecheung
reviewed
Oct 4, 2019
mmarchini
force-pushed
the
non-interactive-mode
branch
from
d8fd92f to
63542c4
Compare
|
Changed to --yes with the behavior described in #366 (comment). |
mmarchini
force-pushed
the
non-interactive-mode
branch
from
63542c4 to
c709d08
Compare
mmarchini
force-pushed
the
non-interactive-mode
branch
from
c709d08 to
3e3fd17
Compare
targos
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
SGTM. Please update the documentation at https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-land
mmarchini
force-pushed
the
non-interactive-mode
branch
from
3e3fd17 to
343865a
Compare
|
@targos done! |
Non-interactive mode will try to land a Pull Request without asking any questions. This is meant to be used by scripts and CI landing tools.
mmarchini
force-pushed
the
non-interactive-mode
branch
from
343865a to
d669ecc
Compare
|
CI is passing 🎉 @targos do you mind landing this? I don't have commit access here. |
|
@mmarchini merged! |
|
released in 1.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-interactive mode will try to land a Pull Request without asking any
questions. This is meant to be used by scripts and CI landing tools.