-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
/cc @bnoordhuis @rvagg Think your feedback would be valuable here as well. |
|
||
Author: Fedor Indutny <fedor@indutny.com> | ||
Status: draft | ||
Date: Thu Dec 17 2015 19:39:46 GMT-0500 (EST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider doing this how is done in LEPS (https://raw.githubusercontent.com/libuv/leps/master/001-remove-unix-support.md). As this is now all these entries will be placed on the same line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this?
// **(optional)** | ||
// Try to write provided data immediately without blocking, if not | ||
// possible to do - should return `0` if no data was written, should decrement | ||
// `count` and change pointers/length in `bufs` if some data was written. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include a helper function or whatnot for recalculating the uv_buf_t**
? We have the logic already in StreamWrap::DoTryWrite()
, and it'd be a shame for everyone to need to implement basically the exact same on their own.
This might not be in-scope for this NEP, but one of the more interesting attributes of WHATWG streams is the ability to do brand-checking during |
Sorry for delay, I took it to consider things more carefully. Turns out, I agree with @bnoordhuis , adding this won't really create more value than problems. Let's close this for now. Thank you for your time, and sorry for wasting it on this. 😞 |
@indutny :( The concept was good. Hopefully we can figure out how to get something like this into core in the future. |
We have this in core already :) I'm not suggesting to remove it, just don't think that making it public would be beneficial. |
Sorry. should have read "as public API in core" |
Forgot that even rejected proposals are still merged. Landed in 9faa231. |
What's the status of this proposal in core? Was it exposed? |
I believe the proposal was rejected. The APIs are not exposed. |
cc @trevnorris