lib: fail gracefully if we can't find the username (#2375)

nodejs · May 19, 2021 · fca4795 · fca4795
1 parent 07e9d7c
commit fca4795
Showing 1 changed file with 23 additions and 8 deletions.
diff --git a/lib/find-python.js b/lib/find-python.js
@@ -8,20 +8,35 @@ const win = process.platform === 'win32'
 const logWithPrefix = require('./util').logWithPrefix
 
 const systemDrive = process.env.SystemDrive || 'C:'
-const username = process.env.USERNAME || process.env.USER || require('os').userInfo().username
+const username = process.env.USERNAME || process.env.USER || getOsUserInfo()
 const localAppData = process.env.LOCALAPPDATA || `${systemDrive}\\${username}\\AppData\\Local`
+const foundLocalAppData = process.env.LOCALAPPDATA || username
 const programFiles = process.env.ProgramW6432 || process.env.ProgramFiles || `${systemDrive}\\Program Files`
 const programFilesX86 = process.env['ProgramFiles(x86)'] || `${programFiles} (x86)`
 
 const winDefaultLocationsArray = []
 for (const majorMinor of ['39', '38', '37', '36']) {
-  winDefaultLocationsArray.push(
-    `${localAppData}\\Programs\\Python\\Python${majorMinor}\\python.exe`,
-    `${programFiles}\\Python${majorMinor}\\python.exe`,
-    `${localAppData}\\Programs\\Python\\Python${majorMinor}-32\\python.exe`,
-    `${programFiles}\\Python${majorMinor}-32\\python.exe`,
-    `${programFilesX86}\\Python${majorMinor}-32\\python.exe`
-  )
+  if (foundLocalAppData) {
+    winDefaultLocationsArray.push(
+      `${localAppData}\\Programs\\Python\\Python${majorMinor}\\python.exe`,
+      `${programFiles}\\Python${majorMinor}\\python.exe`,
+      `${localAppData}\\Programs\\Python\\Python${majorMinor}-32\\python.exe`,
+      `${programFiles}\\Python${majorMinor}-32\\python.exe`,
+      `${programFilesX86}\\Python${majorMinor}-32\\python.exe`
+    )
+  } else {
+    winDefaultLocationsArray.push(
+      `${programFiles}\\Python${majorMinor}\\python.exe`,
+      `${programFiles}\\Python${majorMinor}-32\\python.exe`,
+      `${programFilesX86}\\Python${majorMinor}-32\\python.exe`
+    )
+  }
+}
+
+function getOsUserInfo () {
+  try {
+    return require('os').userInfo().username
+  } catch {}
 }
 
 function PythonFinder (configPython, callback) {