Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add a note for using configure on Windows #1152

Closed
wants to merge 1 commit into from
Closed

doc: add a note for using configure on Windows #1152

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Fixes: #1149

@vsemozhetbyt
Copy link
Contributor Author

I am not sure about the proper place or wording. Please, correct me.

@vsemozhetbyt vsemozhetbyt mentioned this pull request Mar 21, 2017
Closed
bnoordhuis
bnoordhuis reviewed Mar 21, 2017
View reviewed changes
README.md Outdated
@@ -91,6 +91,11 @@ platform. Use `configure` for that:
$ node-gyp configure
```

For some Windows configurations, you may need to add `--msvs_version=2015` key:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd explain that it's only needed when auto-detection fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK?

@joaocgreis
Copy link
Member

@vsemozhetbyt thanks for opening this PR!

I would make it something like: "Auto-detection fails for Visual C++ Build Tools 2015, so --msvs_version=2015 needs to be added (not needed when run by npm as configured above):"

We can be clear about VCBT2015, because it is exactly and only for it that GYP fails to autodetect.

@vsemozhetbyt
Copy link
Contributor Author

@joaocgreis Done.

@vsemozhetbyt
Copy link
Contributor Author

@joaocgreis @bnoordhuis @gibfahn Can we land this? See #1149 (comment)

@gibfahn
Copy link
Member

gibfahn commented Apr 23, 2017

Based on #1153 (comment), yes!

It's no different from other repos: run CI, add commit metadata, merge. Anyone with write access can (and is welcome to) land patches.

CI just in case: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/10/

@vsemozhetbyt
Copy link
Contributor Author

@gibfahn But I have not write access here)

gibfahn pushed a commit that referenced this pull request Apr 23, 2017
@vsemozhetbyt @gibfahn
doc: add a note for using configure on Windows
c09cf76 
PR-URL: #1152
Fixes: #1149
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Apr 23, 2017

Landed in c09cf76

cc/ @bnoordhuis in case I messed something up.

@gibfahn gibfahn closed this Apr 23, 2017
@vsemozhetbyt vsemozhetbyt deleted the msvs_version-key branch April 23, 2017 16:32
refack
refack reviewed Apr 23, 2017
View reviewed changes
README.md
@@ -91,6 +91,12 @@ platform. Use `configure` for that:
$ node-gyp configure
```

Auto-detection fails for Visual C++ Build Tools 2015, so `--msvs_version=2015`
needs to be added (not needed when run by npm as configured above):
``` bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could do ```ShellSession since it's not bash

refack
refack reviewed Apr 23, 2017
View reviewed changes
README.md
Auto-detection fails for Visual C++ Build Tools 2015, so `--msvs_version=2015`
needs to be added (not needed when run by npm as configured above):
``` bash
$ node-gyp configure --msvs_version=2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like c:\node>

refack
refack reviewed Apr 23, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe be more Windows specific

@refack
Copy link
Contributor

refack commented Apr 23, 2017

Off I just missed the action :(

@vsemozhetbyt
Copy link
Contributor Author

Yeah, it was a bit untidily from me, sorry.

@gibfahn
Copy link
Member

gibfahn commented Apr 23, 2017

@refack feel free to submit a PR!

@refack refack mentioned this pull request Apr 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@gibfahn gibfahn gibfahn approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@joaocgreis joaocgreis joaocgreis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @joaocgreis @gibfahn @refack @bnoordhuis