Fix test-find-python on v0.10.x buildbot. #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around a v0.10.x CI issue where path.resolve() on UNIX systems prefixes Windows paths with the current working directory. v0.12 and up are free of this issue because they use path.win32.resolve() which does the right thing.
|
Green! Can I get a LGTM? |
gibfahn
approved these changes
Apr 25, 2017
richardlau
approved these changes
Apr 25, 2017
|
Another CI run as the last one has disappeared off of Jenkins: https://ci.nodejs.org/job/nodegyp-test-pull-request/12/ I've confirmed that this fixes the 0.10 issue locally. |
gibfahn
pushed a commit
that referenced
this pull request
Apr 25, 2017
Work around a v0.10.x CI issue where path.resolve() on UNIX systems prefixes Windows paths with the current working directory. v0.12 and up are free of this issue because they use path.win32.resolve() which does the right thing. PR-URL: #1172 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 4980171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around a v0.10.x CI issue where path.resolve() on UNIX systems
prefixes Windows paths with the current working directory.
v0.12 and up are free of this issue because they use
path.win32.resolve() which does the right thing.
CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/9/