Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused gyp test scripts. #1458

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Remove unused gyp test scripts. #1458

merged 1 commit into from
Jun 8, 2018

Conversation

bnoordhuis
Copy link
Member

Shrinks node-gyp's size by about 100 kB.

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think we'll ever take another upstream gyp? If so, then maybe add these to gitignore so they don't come back?

Shrinks node-gyp's size by about 100 kB.

PR-URL: #1458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@bnoordhuis bnoordhuis merged commit 50b8734 into nodejs:master Jun 8, 2018
@bnoordhuis bnoordhuis deleted the rm-gyp-stuff branch June 8, 2018 15:28
@bnoordhuis
Copy link
Member Author

Do we think we'll ever take another upstream gyp?

Unlikely in the extreme.

bnoordhuis added a commit that referenced this pull request Jun 8, 2018
Shrinks node-gyp's size by about 100 kB.

PR-URL: #1458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants