test: configure proper devDir for invoking configure() #1796
Conversation
Just to double check -- we still download the headers at least once elsewhere in the tests? |
|
@richardlau maybe not, maybe I'll add one to test-download.js which mocks it all out I think. |
Another way to check would be to see if coverage drops after this PR (now we're using |
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
9b3f6d0
to
ee46c5c
Compare
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
ee46c5c
to
c3dfcec
Compare
|
I've rebased this and added a whole new test that downloads headers and verifies contents. @nodejs/node-gyp ptal. |
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
c3dfcec
to
43fa2df
Compare
test/test-configure-python.js downloads a fresh set of headers to the package directory each time. By setting to the default global cache dir we get to re-use cached headers and skip the download step. PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
43fa2df
to
0670e51
Compare
|
landed |
test/test-configure-python.js downloads a fresh set of headers to the package directory each time. By setting to the default global cache dir we get to re-use cached headers and skip the download step. PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
test/test-configure-python.js downloads a fresh set of headers to the package directory each time. By setting to the default global cache dir we get to re-use cached headers and skip the download step. Speeds up tests and prevents the creation of a new directory with headers in it in the package root each test run.