Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from __future__ import with_statement #1799

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 25, 2019

This __future__ import is no longer required in Python >= 2.6.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

This \_\_future\_\_ import is no longer required in Python >= 2.6.  https://docs.python.org/2/library/__future__.html
rvagg pushed a commit that referenced this pull request Jun 26, 2019
This \_\_future\_\_ import is no longer required in Python >= 2.6.  https://docs.python.org/2/library/__future__.html

PR-URL: #1799
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented Jun 26, 2019

landed in afaaa29

also FYI, commit message became: gyp: remove from __future__ import with_statement

metadata in commit summary:

PR-URL: https://github.com/nodejs/node-gyp/pull/1799
Reviewed-By: Rod Vagg <rod@vagg.org>

@rvagg rvagg closed this Jun 26, 2019
@rvagg rvagg deleted the Remove-from-__future__-import-with_statement branch June 26, 2019 05:32
@rvagg
Copy link
Member

rvagg commented Jun 26, 2019

maybe I should have left this a bit longer, only 21 hours, it's pretty trivial but I guess we should have a proper delay to allow more eyes in future

@rvagg rvagg mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants