-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI: Add parallel test runs on macOS and Windows #1800
Conversation
.travis.yml
Outdated
before_install: choco install python2 | ||
allow_failures: | ||
- os: windows | ||
- python: 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we expecting failures on windows now that #1793 is landed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3 yes but Windows no. See comments below.
both of these commits should probably be prefixed with |
Please stress test Python 3. Note that the Windows run is still in __allow_failures__ mode but that should be fixed in a separate PR.
Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use So what I do in cases like this goes something like this:
and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:
Fixing this branch might be a bit awkward now. What I'd probably do to land it is If you're happy with this I could probably do all that and land it if you'd like. |
Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs. |
Note that the Windows run is in __allow_failures__ mode but that should be fixed in a separate PR. PR-URL: #1800 Reviewed-By: Rod Vagg <rod@vagg.org>
squashed into one commit and landed into b93bac9 |
sorry, 7a9a038 |
Note that the Windows run is in __allow_failures__ mode but that should be fixed in a separate PR. PR-URL: #1800 Reviewed-By: Rod Vagg <rod@vagg.org>
Checklist
npm install && npm test
passesDescription of change
Travis CI: Add parallel test runs on macOS and Windows
Windows and Python 3 run in allow_failures mode until we are ready to support them.