Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover supported node versions with travis #1809

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ matrix:
include:
- name: "Python 2.7 on Linux"
python: 2.7
- name: "Python 3.7 on Linux"
python: 3.7
- name: "Python 2.7 on macOS"
os: osx
osx_image: xcode10.2
Expand All @@ -18,6 +16,18 @@ matrix:
node_js: 12 # node
env: PATH=/c/Python27:/c/Python27/Scripts:$PATH
before_install: choco install python2
- name: "Node.js 6 & Python 3.7 on Linux"
python: 3.7
before_install: nvm install 6
- name: "Node.js 8 & Python 3.7 on Linux"
python: 3.7
before_install: nvm install 8
- name: "Node.js 10 & Python 3.7 on Linux"
python: 3.7
before_install: nvm install 10
- name: "Node.js 12 & Python 3.7 on Linux"
python: 3.7
before_install: nvm install 12
allow_failures:
- os: windows
Copy link
Contributor

@cclauss cclauss Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add python: 3.7 to allow_failures ;-)

install:
Expand All @@ -26,7 +36,7 @@ install:
before_script:
- flake8 --version
# stop the build if there are Python syntax errors or undefined names
- flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics
- flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. Two space indentation is OK. The GitHub editor is 127 chars wide
- flake8 . --count --exit-zero --ignore=E111,E114,W503 --max-complexity=10 --max-line-length=127 --statistics
- npm install
Expand Down