Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build,test: add duplicate symbol test" #1828

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Revert "build,test: add duplicate symbol test" #1828

merged 1 commit into from
Jul 16, 2019

Commits on Jul 16, 2019

  1. Revert "build,test: add duplicate symbol test" 

    This reverts commit 2761afb.

Building with `-fvisibility=hidden` breaks some of Node's add-on tests
and therefore likely also affects third-party add-ons. This change was
landed in a patch release so I'm opting to revert it until the next
major release.

PR-URL: #1828
Refs: nodejs/node#28647 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    c9a86fe View commit details
    Browse the repository at this point in the history