Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix macOS Travis builds #1980

Closed
wants to merge 2 commits into from
Closed

test: fix macOS Travis builds #1980

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 28, 2019

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Fix the broken Travis CI build for Python 2.7 and 3.7.

@rvagg
Copy link
Member

rvagg commented Nov 29, 2019

it looks like your first commit got pushed to master, but with a different summary, as c392a17. I've force pushed it out and it can go back in here, or #1979, wherever appropriate. I don't really understand the relationship between the two of these PRs.

@rvagg rvagg mentioned this pull request Nov 29, 2019
Closed
1 task
@cclauss
Copy link
Contributor Author

cclauss commented Nov 29, 2019

Closing in favor of #1979. My mistake on committing to master (again!) sorry for that. Thank you for catching and reverting.

@cclauss cclauss closed this Nov 29, 2019
@Trott Trott deleted the Fix-macOS-Travis-builds branch September 28, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @rvagg